Repository navigation
Initial RDK CI support - #5338
Conversation
|
Blocked by open sourcing the BSP |
b7d07a4 to
3a3614f
Compare
3a3614f to
d288c99
Compare
b/406991008
…r.py` on RDK docker b/415848657
a9f7387 to
dd56ec4
Compare
|
Some notes on changes:
|
| @@ -26,14 +27,18 @@ runs: | |||
| else | |||
| BUILD_PLATFORM=${COBALT_EVERGREEN_LOADER} | |||
| BUILD_TARGET='loader_app_install elf_loader_sandbox_install native_target/crashpad_handler' | |||
There was a problem hiding this comment.
Can you inline ${{ matrix.evergreen_loader_extra_build_targets }} in this line instead?
There was a problem hiding this comment.
Yes, I could, I was just trying to follow the same pattern used for extra_gn_arguments in .github/actions/build/action.yaml. That said, would you still prefer inline? Please let me know and I will update accordingly.
There was a problem hiding this comment.
File level nit: pad variable name with spaces in the double curlies:
${{matrix.extra_build_targets}} -> ${{ matrix.extra_build_targets }}
There was a problem hiding this comment.
That is fine to me, but similar to the previous comment, I was trying to follow the pattern already used in the file where they usually (in most cases) don't pad with spaces (same is valid for other actions (e.g. .github/actions/gn/action.yaml). Please confirm if you'd still want this change and if so whether to update only the lines I'm touching for the changes here or to update the whole file.
niranjanyardi
left a comment
niranjanyardi
left a comment
There was a problem hiding this comment.
lgtm apart from the open comments by oxv
|
@oxve both the changes look like nits to me . We can ask Andre to work on them in a follow up |
|
gemini /review |
|
Hi @isarkis, thanks for the request! It looks like you tried to invoke the |
|
|
||
| # TODO(b/402053134): fetch and extract the RDK sysroot at $RDK_HOME, once the sysroot is public available | ||
| # Get the toolchain package. | ||
| RUN cd /tmp \ |
There was a problem hiding this comment.
@andrunko can we please change this command to reuse the script: starboard/contrib/rdk/src/third_party/starboard/rdk/arm/tools/download_and_install_rdk_bsp.sh
We are using the same scripts for developers to install it locally, we can resue it in the docker container
Add github actions to build RDK evergreen platform
Depends on #5166.
b/406991008