Repository navigation
Improve starboard::shared::starboard::media::AvcParameterSets class to handle optional parameters - #5326
Merged
jasonzhangxx merged 4 commits intoMay 21, 2025
Conversation
jasonzhangxx
reviewed
Apr 9, 2025
jasonzhangxx
reviewed
Apr 9, 2025
iuriionishchenko
force-pushed
the
Improve_AvcParameterSets_to_add_optional_parameter
branch
from
April 10, 2025 07:57
8febb79 to
7ff8686
Compare
iuriionishchenko
force-pushed
the
Improve_AvcParameterSets_to_add_optional_parameter
branch
from
April 15, 2025 11:23
7ff8686 to
bb2d98b
Compare
jasonzhangxx
approved these changes
Apr 23, 2025
Contributor
|
Can you help to make a pr to apply the change to main branch? |
Collaborator
Author
I have created new pr #5590 |
iuriionishchenko
force-pushed
the
Improve_AvcParameterSets_to_add_optional_parameter
branch
from
April 29, 2025 14:47
6547efe to
60f892f
Compare
…o handle optional parameters b/392649786 Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
iuriionishchenko
force-pushed
the
Improve_AvcParameterSets_to_add_optional_parameter
branch
from
April 29, 2025 14:56
60f892f to
da37c4d
Compare
Collaborator
Author
|
There is one failing. But the failing is not related on my changes. I think it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve starboard::shared::starboard::media::AvcParameterSets class to handle optional parameters
b/392649786
Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c