Skip to content

Avoid pre-commit checks on starboard/contrib/RDK (#5248) - #5263

Merged
niranjanyardi merged 2 commits into
youtube:mainfrom
niranjanyardi:avoid_sb_contrib_rdk_precommit_checks
Apr 4, 2025
Merged

Avoid pre-commit checks on starboard/contrib/RDK (#5248)#5263
niranjanyardi merged 2 commits into
youtube:mainfrom
niranjanyardi:avoid_sb_contrib_rdk_precommit_checks

Conversation

@niranjanyardi

@niranjanyardi niranjanyardi commented Apr 1, 2025

Copy link
Copy Markdown
Member

b/406054987

@niranjanyardi
niranjanyardi requested review from kaidokert and oxve April 1, 2025 20:51
@niranjanyardi
niranjanyardi marked this pull request as ready for review April 1, 2025 20:53
@niranjanyardi
niranjanyardi requested a review from a team as a code owner April 1, 2025 20:53
@niranjanyardi
niranjanyardi force-pushed the avoid_sb_contrib_rdk_precommit_checks branch 2 times, most recently from 06c7f50 to 4b6b131 Compare April 1, 2025 21:42
oxve
oxve reviewed Apr 1, 2025
View reviewed changes
Comment thread .pre-commit-config.yaml Resolved
oxve
oxve reviewed Apr 1, 2025
View reviewed changes
Comment thread .pre-commit-config.yaml Resolved
Comment thread .pre-commit-config.yaml Resolved
@oxve

oxve commented Apr 1, 2025

Copy link
Copy Markdown
Member

Can you also verify that it works when you run pre-commit locally with files under the RDK dir?

@niranjanyardi
niranjanyardi force-pushed the avoid_sb_contrib_rdk_precommit_checks branch from 4b6b131 to 4a995c3 Compare April 2, 2025 19:10
@niranjanyardi

niranjanyardi commented Apr 2, 2025

Copy link
Copy Markdown
Member Author

Can you also verify that it works when you run pre-commit locally with files under the RDK dir?

yep, works: i made a change in the RDK folder:

check for case conflicts.............................(no files to check)Skipped
check xml............................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
mixed line ending....................................(no files to check)Skipped
trim trailing whitespace.............................(no files to check)Skipped
Spell Check..........................................(no files to check)Skipped
clang-format.........................................(no files to check)Skipped
yapf.................................................(no files to check)Skipped
pylint...............................................(no files to check)Skipped
Python 3 Compatibility Check.........................(no files to check)Skipped
google-java-format...................................(no files to check)Skipped
gcheckstyle..........................................(no files to check)Skipped
gn-format............................................(no files to check)Skipped

@niranjanyardi
niranjanyardi force-pushed the avoid_sb_contrib_rdk_precommit_checks branch from 4a995c3 to 45fd446 Compare April 2, 2025 19:12
kaidokert
kaidokert approved these changes Apr 4, 2025
View reviewed changes

@kaidokert kaidokert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine

kaidokert
kaidokert reviewed Apr 4, 2025
View reviewed changes
Comment thread .pre-commit-config.yaml Resolved
@niranjanyardi
niranjanyardi merged commit bafec44 into youtube:main Apr 4, 2025
kaidokert pushed a commit to kaidokert/cobalt that referenced this pull request Jun 15, 2025
@niranjanyardi
Avoid pre-commit checks on starboard/contrib/RDK (youtube#5248) (yout…
2ffb675 
…ube#5263)

b/406054987
briantting pushed a commit that referenced this pull request Jul 1, 2025
@niranjanyardi
Avoid pre-commit checks on starboard/contrib/RDK (#5248) (#5263)
dc08f5c 
b/406054987
original-hexsha: bafec44
briantting pushed a commit that referenced this pull request Jul 11, 2025
@niranjanyardi @briantting
Avoid pre-commit checks on starboard/contrib/RDK (#5248) (#5263)
e133a9c 
b/406054987
original-hexsha: bafec44
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 25, 2025
@niranjanyardi @sideb0ard
Avoid pre-commit checks on starboard/contrib/RDK (youtube#5248) (yout…
f891220 
…ube#5263)

b/406054987
original-hexsha: bafec44
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 26, 2025
@niranjanyardi @sideb0ard
Avoid pre-commit checks on starboard/contrib/RDK (youtube#5248) (yout…
d96ed66 
…ube#5263)

b/406054987
original-hexsha: bafec44
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 30, 2025
@niranjanyardi @sideb0ard
Avoid pre-commit checks on starboard/contrib/RDK (youtube#5248) (yout…
8f851c3 
…ube#5263)

b/406054987
original-hexsha: bafec44
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Aug 12, 2025
@niranjanyardi @sideb0ard
Avoid pre-commit checks on starboard/contrib/RDK (youtube#5248) (yout…
8e39675 
…ube#5263)

b/406054987
original-hexsha: bafec44
briantting pushed a commit that referenced this pull request Aug 15, 2025
@niranjanyardi
Avoid pre-commit checks on starboard/contrib/RDK (#5248) (#5263)
17b6323 
b/406054987

original-hexsha: bafec44
sideb0ard pushed a commit that referenced this pull request Aug 20, 2025
@niranjanyardi @sideb0ard
Avoid pre-commit checks on starboard/contrib/RDK (#5248) (#5263)
a232458 
b/406054987

original-hexsha: bafec44
briantting pushed a commit that referenced this pull request Aug 29, 2025
@niranjanyardi @briantting
Avoid pre-commit checks on starboard/contrib/RDK (#5248) (#5263)
de16ef0 
b/406054987

original-hexsha: bafec44
madhurajayaraman pushed a commit to madhurajayaraman/cobalt that referenced this pull request Sep 8, 2025
@niranjanyardi @madhurajayaraman
Avoid pre-commit checks on starboard/contrib/RDK (youtube#5248) (yout…
7250b3c 
…ube#5263)

b/406054987

original-hexsha: bafec44
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Sep 10, 2025
@niranjanyardi @sideb0ard
Avoid pre-commit checks on starboard/contrib/RDK (youtube#5248) (yout…
ee1b7ff 
…ube#5263)

b/406054987

original-hexsha: bafec44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oxve oxve oxve left review comments
+1 more reviewer
@kaidokert kaidokert kaidokert approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@niranjanyardi @oxve @kaidokert