Skip to content

Add "specify a lts branch when cloning Cobalt" - #5243

Merged
kaidokert merged 1 commit into
youtube:25.lts.1+from
billy0059:25.lts.1+
Apr 1, 2025
Merged

kaidokert merged 1 commit into
youtube:25.lts.1+from
billy0059:25.lts.1+

Conversation

@billy0059

Copy link
Copy Markdown
Contributor

Add "specify a lts branch when cloning Cobalt". Since the main branch of Cobalt is now Chromium.

b/403778590

@billy0059

Copy link
Copy Markdown
Contributor Author

Hi @lamdbui ,
I learned from @jonastsai that we submit changes to Github for issues in Cobalt.
Please help to review the PR and please let me know if there is anything wrong.

Thanks,
Billy

@lamdbui
lamdbui requested review from kaidokert and oxve March 31, 2025 18:06
@lamdbui

lamdbui commented Mar 31, 2025

Copy link
Copy Markdown
Member

Thanks @billy0059 . This is fine with me. I think we'll probably have to also update the documentation for the main branch with updated build steps in the near future as well.

@kaidokert @oxve ,
Any issues with this change?

@kaidokert kaidokert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine as is.

I had some second thoughts because we'll want to update the instructions eventually for Chrobalt, but that'll have to pretty much be a new page / instructions entirely. So this 25.lts doc here will be valuable for people for several years from now stil..

@oxve oxve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kaidokert
kaidokert merged commit d36dfec into youtube:25.lts.1+ Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants