Repository navigation
[net_unittests] Sort cookies for deterministic order - #5217
Merged
Merged
Conversation
andrewsavage1
approved these changes
Apr 3, 2025
andrewsavage1
left a comment
andrewsavage1
left a comment
Contributor
There was a problem hiding this comment.
Fine with this going in as is to the 25.lts.1+ branch but we would want a different long-term solution that's shared with Chromium, which is probably making sure the cookies have different timestamps so they're sorted deterministically.
b/219056504 Modified the test to split and sort the cookies before comparing. Previously, a single semicolon-delimited string was compared, but since cookies come from different maps and are sorted by date which may be identical their order can vary between test runs. This change ensures a consistent order for accurate comparisons.
kaidokert
force-pushed
the
fix_net_test_3
branch
from
April 7, 2025 16:50
3d6378e to
346d60c
Compare
kaidokert
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/219056504
Modified the test to split and sort the cookies before comparing. Previously, a single semicolon-delimited string was compared, but since cookies come from different maps and are sorted by date which may be identical their order can vary between test runs. This change ensures a consistent order for accurate comparisons.