Repository navigation
[net_unittests] Normalize newline characters in tests - #5215
Merged
Merged
Conversation
msolya
requested review from
amurovanyi and
andrewsavage1
and removed request for
andrewsavage1
March 27, 2025 09:20
b/219056504 Fixed tests where the expected newline was LF (\n) but some files and data contained CRLF (\r\n). In some cases, the code was modified to replace \r\n with \n for normalization. In other instances, where a string with \n was expected, the expected string was adjusted by removing that character, and the actual output underwent whitespace collapsing (removing \r\n).
TyHolc
approved these changes
Apr 1, 2025
TyHolc
left a comment
TyHolc
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just working on getting those 3 failed builds to pass. It looks like they should be unrelated to this change.
Contributor
|
Looks like there is a single failed test that might be related to this change: Not sure if that is just a coincidentally failing test or if some of the extra string trimming broke the expiration date check for the cert in that test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/219056504
Fixed tests where the expected newline was LF (\n) but some files and data contained CRLF (\r\n). In some cases, the code was modified to replace \r\n with \n for normalization. In other instances, where a string with \n was expected, the expected string was adjusted by removing that character, and the actual output underwent whitespace collapsing (removing \r\n).