Repository navigation
[android] Fix incorrect mute status detection in Key Event handling - #5195
Merged
Merged
Conversation
jonastsai
reviewed
Apr 1, 2025
hlwarriner
requested changes
Apr 1, 2025
hlwarriner
left a comment
hlwarriner
left a comment
Member
There was a problem hiding this comment.
I left a few minor comments about the style but otherwise the changes look good.
That said, while I read through the bug and these changes sound reasonable, I wasn't involved in the "internal discussion" mentioned in https://b.corp.google.com/issues/401163510#comment5.
@jonastsai, can you please make sure that anyone from the Cobalt team involved in these discussions is added as a reviewer?
weifang-cool
force-pushed
the
fix-on-25lts1plus
branch
from
April 8, 2025 11:17
4274f35 to
6722277
Compare
weifang-cool
force-pushed
the
fix-on-25lts1plus
branch
from
April 27, 2025 03:38
6722277 to
aa10ea5
Compare
jonastsai
reviewed
Apr 30, 2025
weifang-cool
force-pushed
the
fix-on-25lts1plus
branch
from
April 30, 2025 10:16
aa10ea5 to
1e62244
Compare
Fix cobalt apk Key Event Volume Mute status error cobalt apk should use EXTRA_VOLUME_STREAM_TYPE and EXTRA_STREAM_VOLUME_MUTED to determine the mute status b/401163510 Change-Id: Ib7ef74ea33c27003d1778b59c12eb797ecd0a3e9
jonastsai
force-pushed
the
fix-on-25lts1plus
branch
from
May 15, 2025 05:24
1e62244 to
38e9088
Compare
jonastsai
enabled auto-merge (squash)
May 15, 2025 08:33
zhongqiliang
approved these changes
May 19, 2025
hlwarriner
self-requested a review
May 19, 2025 17:56
hlwarriner
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cobalt apk Key Event Volume Mute status error
cobalt apk should use EXTRA_VOLUME_STREAM_TYPE and EXTRA_STREAM_VOLUME_MUTED to determine the mute status
b/401163510