Repository navigation
Revert dynamic test target calculation - #5130
Merged
Merged
Conversation
Contributor
Author
|
Note i still need to update the actual static lists to the new set separately as well. I'm checking if this bypass works correctly first. |
kaidokert
marked this pull request as draft
March 20, 2025 19:42
kaidokert
marked this pull request as ready for review
March 20, 2025 20:45
andrewsavage1
approved these changes
Mar 20, 2025
andrewsavage1
left a comment
andrewsavage1
left a comment
Contributor
There was a problem hiding this comment.
Assuming the test_targets.json files are just reverts, this LGTM
Contributor
Author
They technically aren't - i'm syncing the targets up to what the dynamic calculation was resolving to. E.g. ensure that our coverage stays the same. |
Contributor
As long as it passes still seems fine |
imindich
approved these changes
Mar 20, 2025
kaidokert
changed the title
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397
kaidokert
enabled auto-merge (squash)
March 21, 2025 02:51
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
kaidokert
added a commit
that referenced
this pull request
Mar 21, 2025
kaidokert
added a commit
that referenced
this pull request
Mar 21, 2025
Refer to the original PR: #5130 Partial revert of #4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 Co-authored-by: Kaido Kert <[email protected]>
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
Jun 15, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397
briantting
pushed a commit
that referenced
this pull request
Jul 1, 2025
briantting
pushed a commit
that referenced
this pull request
Jul 11, 2025
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 25, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 original-hexsha: a32c619
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 26, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 original-hexsha: a32c619
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 30, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 original-hexsha: a32c619
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Aug 12, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 original-hexsha: a32c619
briantting
pushed a commit
that referenced
this pull request
Aug 15, 2025
sideb0ard
pushed a commit
that referenced
this pull request
Aug 19, 2025
briantting
pushed a commit
that referenced
this pull request
Aug 29, 2025
madhurajayaraman
pushed a commit
to madhurajayaraman/cobalt
that referenced
this pull request
Sep 8, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 original-hexsha: a32c619
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Sep 10, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 original-hexsha: a32c619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of #4464, as it currently doesn't reliably find all changed tests.
Also - dynamic calculation should always be bypassed for post-submits
b/382508397