Skip to content

starboard: roll up the remaining unittest targets - #5127

Merged
yell0wd0g merged 17 commits into
youtube:mainfrom
yell0wd0g:b_384819454__3__roll_more_starboard_unittests
Apr 14, 2025
Merged

yell0wd0g merged 17 commits into
youtube:mainfrom
yell0wd0g:b_384819454__3__roll_more_starboard_unittests

Conversation

@yell0wd0g

@yell0wd0g yell0wd0g commented Mar 20, 2025 •

Copy link
Copy Markdown
Contributor

This PR continues the work of #4831 and rolls up all other targets I could find that looked like unit tests into starboard_unittests.

With this I see

[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST

(the disabled test was from before, the skipped ones are new, see further below).

Media-related topics:

  • A number of tetst (e.g. AudioDecoderTest and others) needed a number of system libraries to support codecs like AAC, AC3 etc but those are part of non-free Debian repos, so couldn't install those in Docker. This CL adds a new method IsProprietaryAudioCodec() to be used to SKIP test cases related to those codecs, when the build flag SKIP_PROPRIETARY_CODEC_TESTS is present.
  • VideoDecoderTests and PlayerComponentsTest failed flakily due to X11 use not being torn down correctly; they need xvfb-run. This makes me think those are not pure unit-tests but integration tests like nplb. For the time being they are commented out with a TODO.
  • media_util_test.cc needed operator== on SbMediaColorMetadatas, so I added it as extern.
  • FileCacheReader needs to find the media files under the output folder's content/ directory. Files are under the output folder's starboard/content, because of the starboard toolchain. This CL leaves a quick hack and a TODO() to find a proper solution.

Finally:

  • //starboard/raspi/shared/:starboard_platform_tests target was empty, this CL removes it.

Bug: b/384819454

@yell0wd0g
yell0wd0g force-pushed the b_384819454__3__roll_more_starboard_unittests branch from ae047d9 to 4f2b41b Compare March 21, 2025 23:26
@yell0wd0g
yell0wd0g force-pushed the b_384819454__3__roll_more_starboard_unittests branch from 92e72c3 to c0521e3 Compare April 14, 2025 16:08
@yell0wd0g
yell0wd0g force-pushed the b_384819454__3__roll_more_starboard_unittests branch from 0689146 to bc452d7 Compare April 14, 2025 18:11
@yell0wd0g
yell0wd0g marked this pull request as ready for review April 14, 2025 21:47
@yell0wd0g
yell0wd0g requested a review from kjyoun April 14, 2025 21:48
@yell0wd0g

Copy link
Copy Markdown
Contributor Author

@kjyoun PTAL

@yell0wd0g
yell0wd0g enabled auto-merge (squash) April 14, 2025 22:30
@yell0wd0g
yell0wd0g merged commit 82430e3 into youtube:main Apr 14, 2025
@yell0wd0g yell0wd0g added the cp-26.android Cherry Pick to the 26.android branch label Apr 15, 2025
cobalt-github-releaser-bot pushed a commit that referenced this pull request Apr 15, 2025
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
(cherry picked from commit 82430e3)
yell0wd0g added a commit that referenced this pull request Apr 15, 2025
…ts (#5413)

Refer to the original PR: #5127

This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally: 
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454

Co-authored-by: Miguel Casas <[email protected]>
kaidokert pushed a commit to kaidokert/cobalt that referenced this pull request Jun 15, 2025
This PR continues the work of youtube#4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
briantting pushed a commit that referenced this pull request Jul 1, 2025
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
original-hexsha: 82430e3
briantting pushed a commit that referenced this pull request Jul 11, 2025
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
original-hexsha: 82430e3
rakuco added a commit to rakuco/cobalt that referenced this pull request Jul 23, 2025
The target being referenced does not exist and never has. Depending on
`:starboard_platform_tests` does not work either, as youtube#5127 removed it.
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 25, 2025
Original Message:
starboard: roll up the remaining unittest targets (youtube#5127)

This PR continues the work of youtube#4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
original-hexsha: 82430e3


Files with conflicts:
- starboard/contrib/cast/cast_starboard_api/samples/BUILD.gn
- starboard/linux/shared/player_components_factory.cc
- starboard/loader_app/installation_manager_test.cc
- starboard/loader_app/pending_restart_test.cc
- starboard/shared/starboard/media/media_util_test.cc
- starboard/shared/starboard/player/file_cache_reader.cc
- starboard/shared/starboard/player/filter/testing/adaptive_audio_decoder_test.cc
- starboard/shared/starboard/player/filter/testing/audio_decoder_test.cc
- starboard/shared/starboard/player/filter/testing/player_components_test.cc
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 26, 2025
This PR continues the work of youtube#4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
original-hexsha: 82430e3
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 30, 2025
This PR continues the work of youtube#4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
original-hexsha: 82430e3
sideb0ard pushed a commit that referenced this pull request Aug 15, 2025
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454
original-hexsha: 82430e3
briantting pushed a commit that referenced this pull request Aug 15, 2025
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454

original-hexsha: 82430e3
sideb0ard pushed a commit that referenced this pull request Aug 20, 2025
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454

original-hexsha: 82430e3
briantting pushed a commit that referenced this pull request Aug 29, 2025
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454

original-hexsha: 82430e3
madhurajayaraman pushed a commit to madhurajayaraman/cobalt that referenced this pull request Sep 9, 2025
This PR continues the work of youtube#4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454

original-hexsha: 82430e3
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Sep 10, 2025
This PR continues the work of youtube#4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.

With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[  PASSED  ] 989 tests.
[  SKIPPED ] 465 tests, listed below:
...
  YOU HAVE 1 DISABLED TEST
```

(the disabled test was from before, the skipped ones are new, see
further below).

Media-related topics:

- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.

Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.

Bug: b/384819454

original-hexsha: 82430e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp-26.android Cherry Pick to the 26.android branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants