Repository navigation
Conversation
Contributor
Author
oxve
reviewed
Mar 7, 2025
andrewsavage1
approved these changes
Mar 17, 2025
andrewsavage1
left a comment
andrewsavage1
left a comment
Contributor
There was a problem hiding this comment.
LGTM as long as we see it running in the logs
Contributor
Author
Hmmm I don't see |
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Mar 20, 2025
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Mar 21, 2025
yell0wd0g
force-pushed
the
b_384819454__2__followup_starboard_unittests
branch
2 times, most recently
from
March 26, 2025 02:34
9bad3cc to
0957f3f
Compare
yell0wd0g
force-pushed
the
b_384819454__2__followup_starboard_unittests
branch
from
April 11, 2025 18:25
0957f3f to
9b546fc
Compare
Contributor
Author
|
With the hack, |
yell0wd0g
force-pushed
the
b_384819454__2__followup_starboard_unittests
branch
from
April 11, 2025 23:33
0a12a0b to
4625d9a
Compare
oxve
approved these changes
Apr 11, 2025
oxve
reviewed
Apr 11, 2025
yell0wd0g
force-pushed
the
b_384819454__2__followup_starboard_unittests
branch
from
April 11, 2025 23:41
380370f to
4625d9a
Compare
…d_unittests-for-starboard-toolchain
…not found in out.../ directly
… found, with an explanation.
yell0wd0g
force-pushed
the
b_384819454__2__followup_starboard_unittests
branch
from
April 11, 2025 23:42
4625d9a to
83c4168
Compare
yell0wd0g
enabled auto-merge (squash)
April 11, 2025 23:52
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 12, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 (cherry picked from commit bdaba2e)
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Apr 14, 2025
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Apr 14, 2025
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Apr 14, 2025
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Apr 14, 2025
yell0wd0g
added
cp-26.android
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 (cherry picked from commit bdaba2e)
Collaborator
|
Important Creating the cherry pick PR failed! Check the log at https://github.com/youtube/cobalt/actions/runs/14459461271 for details. |
yell0wd0g
added a commit
that referenced
this pull request
Apr 15, 2025
…5393) Refer to the original PR: #5031 This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 Co-authored-by: Miguel Casas <[email protected]>
kaidokert
pushed a commit
to kaidokert/cobalt
that referenced
this pull request
Jun 15, 2025
This is a follow up to youtube#4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. youtube#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while youtube#4464 is being worked on. Bug: b/384819454
briantting
pushed a commit
that referenced
this pull request
Jul 1, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
briantting
pushed a commit
that referenced
this pull request
Jul 11, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 25, 2025
Original Message: starboard: Create starboard_unittest_wrapper (youtube#5031) This is a follow up to youtube#4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. youtube#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while youtube#4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e Files with conflicts: - starboard/elf_loader/lz4_file_impl_test.cc
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 26, 2025
This is a follow up to youtube#4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. youtube#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while youtube#4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 30, 2025
This is a follow up to youtube#4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. youtube#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while youtube#4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
sideb0ard
pushed a commit
that referenced
this pull request
Aug 15, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
briantting
pushed a commit
that referenced
this pull request
Aug 15, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
sideb0ard
pushed a commit
that referenced
this pull request
Aug 20, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
briantting
pushed a commit
that referenced
this pull request
Aug 29, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
madhurajayaraman
pushed a commit
to madhurajayaraman/cobalt
that referenced
this pull request
Sep 9, 2025
This is a follow up to youtube#4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. youtube#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while youtube#4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Sep 10, 2025
This is a follow up to youtube#4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. youtube#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while youtube#4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #4831 which landed with a TODO to move the newly introduced
starboard_unittestsinto aif (current_toolchain == starboard_toolchain)block, and let external users depend on astarboard_unittests_wrapperinstead.#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on.
Bug: b/384819454