Repository navigation
[libxml] Hashing of empty dict strings isn't deterministic - #5011
Merged
Merged
Conversation
kaidokert
approved these changes
Mar 5, 2025
kaidokert
changed the title
When hashing empty strings which aren't null-terminated, xmlDictComputeFastKey could produce inconsistent results. This could lead to various logic or memory errors, including double frees. For consistency the seed is also taken into account, but this shouldn't have an impact on security. Found by OSS-Fuzz. Fixes youtube#510. (cherry picked from commit 547edbf1cbdccd46b2e8ff322a456eaa5931c5df)
… by commit 7423065. Issue: 399225618 Reviewed-on: youtube#5011
dahlstrom-g
force-pushed
the
CVE-2023-29469
branch
from
March 14, 2025 00:00
441f1e3 to
cfb7103
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: 399225618