Skip to content

Fix rpi docker build - #4994

Merged
kaidokert merged 1 commit into
youtube:25.lts.1+from
andrunko:fix-rpi-docker-build-25-lts
Mar 12, 2025
Merged

kaidokert merged 1 commit into
youtube:25.lts.1+from
andrunko:fix-rpi-docker-build-25-lts

Conversation

@andrunko

@andrunko andrunko commented Feb 28, 2025 •

Copy link
Copy Markdown
Collaborator

b/397743236

Configure it to use an external toolchain and sync other build options.

Fixes the following build errors:

cc1plus: error: unrecognized command line option '-Wno-class-memaccess' [-Werror]
cc1plus: error: unrecognized command line option '-Wno-packed-not-aligned' [-Werror]
cc1plus: all warnings being treated as errors

@google-cla

google-cla Bot commented Feb 28, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@niranjanyardi
niranjanyardi self-requested a review February 28, 2025 18:53
@niranjanyardi
niranjanyardi changed the base branch from 25.lts.stable to 25.lts.1+ February 28, 2025 18:59
Configure it to use an external toolchain and sync other build options.

Fixes the following build errors:
```
cc1plus: error: unrecognized command line option '-Wno-class-memaccess' [-Werror]
cc1plus: error: unrecognized command line option '-Wno-packed-not-aligned' [-Werror]
cc1plus: all warnings being treated as errors
```

Signed-off-by: Andre Moreira Magalhaes <[email protected]>
@niranjanyardi
niranjanyardi force-pushed the fix-rpi-docker-build-25-lts branch from 82d0890 to 4199c8d Compare February 28, 2025 19:12
@niranjanyardi niranjanyardi self-assigned this Mar 3, 2025
@niranjanyardi

niranjanyardi commented Mar 4, 2025 •

Copy link
Copy Markdown
Member

failures look unrelated to Andre's changes
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.28' not found (required by /__e/node20/bin/node)`

@niranjanyardi niranjanyardi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job getting your first PR in!

@niranjanyardi
niranjanyardi requested a review from kaidokert March 4, 2025 06:38
@kaidokert
kaidokert merged commit 0039bee into youtube:25.lts.1+ Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants