Skip to content

Add ScheduleJobDuringShutdown test - #4864

Closed
alexanderbobrovnik wants to merge 1 commit into
youtube:25.lts.1+from
alexanderbobrovnik:b3725-1
Closed

alexanderbobrovnik wants to merge 1 commit into
youtube:25.lts.1+from
alexanderbobrovnik:b3725-1

Conversation

@alexanderbobrovnik

Copy link
Copy Markdown
Collaborator

Adds test to check that proper handling of JobThread shutdown. In current form this test should fail, because std::unique_ptr is not suitable to hold JobThread.

b/372515171

Adds test to check that proper handling of JobThread shutdown.
In current form this test should fail, because std::unique_ptr is
not suitable to hold JobThread.

b/372515171

@sideb0ard sideb0ard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@amurovanyi

Copy link
Copy Markdown
Collaborator

@sideb0ard, please merge this PR, because we don't have corresponding rights.
Thank you!

@sideb0ard

Copy link
Copy Markdown
Member

@sideb0ard, please merge this PR, because we don't have corresponding rights. Thank you!

hi!
I left a comment on #4275
as this now breaks the build (as expected), let's copy the test to #4275, which should now pass. Once we have #4275 merged, we can abandon this change. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants