Repository navigation
Refine SbPlayerGetMediaTimeTest - #4835
Merged
Merged
Conversation
jasonzhangxx
marked this pull request as draft
February 18, 2025 19:57
1. Write audio data from seek to time. 2. Re-enable SbPlayerGetMediaTimeTest for android and win32. b/347961880
jasonzhangxx
force-pushed
the
get-meida-time-test
branch
from
March 6, 2025 22:25
89fae11 to
4ce2b5b
Compare
jasonzhangxx
changed the title
jasonzhangxx
marked this pull request as ready for review
March 10, 2025 18:21
Contributor
Author
|
Though arm64_on_device_2 had a failure result, from its log, it seems that all tests were passed. @oxve |
oxve
approved these changes
Mar 10, 2025
oxve
left a comment
oxve
left a comment
Member
There was a problem hiding this comment.
These tests failed:
SbSocketAddressTypes/SbSocketGetInterfaceAddressTest.SunnyDayDestination/type_ipv6, where GetParam() = 1
SbSocketAddressTypes/SbSocketGetInterfaceAddressTest.SunnyDaySourceForDestination/type_ipv6, where GetParam() = 1
SbSocketAddressTypes/SbSocketGetInterfaceAddressTest.SunnyDaySourceNotLoopback/type_ipv6, where GetParam() = 1
Looks unrelated to the change
borongc
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/347961880