Repository navigation
Add script that generates list of test targets - #4464
Merged
Merged
Conversation
oxve
force-pushed
the
test-targets
branch
17 times, most recently
from
December 29, 2024 18:19
a1f4e8d to
dfe8727
Compare
oxve
marked this pull request as draft
December 30, 2024 18:33
kaidokert
reviewed
Dec 30, 2024
b/382508397
Consider entire tree if no sources were provided or no targets found.
imindich
approved these changes
Mar 14, 2025
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
Mar 20, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
Mar 20, 2025
This reverts commit 292be22.
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
Mar 21, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
Mar 21, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397
kaidokert
added a commit
that referenced
this pull request
Mar 21, 2025
Partial revert of #4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
kaidokert
added a commit
that referenced
this pull request
Mar 21, 2025
kaidokert
added a commit
that referenced
this pull request
Mar 21, 2025
Refer to the original PR: #5130 Partial revert of #4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 Co-authored-by: Kaido Kert <[email protected]>
yell0wd0g
added a commit
that referenced
this pull request
Apr 12, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 12, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 (cherry picked from commit bdaba2e)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 (cherry picked from commit bdaba2e)
yell0wd0g
added a commit
that referenced
this pull request
Apr 15, 2025
…5393) Refer to the original PR: #5031 This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 Co-authored-by: Miguel Casas <[email protected]>
kaidokert
pushed a commit
to kaidokert/cobalt
that referenced
this pull request
Jun 15, 2025
Add script that calculates test targets based on gn deps is added to the build step. The output from this script is then passed through the build pipeline to each of the steps that use the list. b/382508397
kaidokert
added a commit
to kaidokert/cobalt
that referenced
this pull request
Jun 15, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397
kaidokert
pushed a commit
to kaidokert/cobalt
that referenced
this pull request
Jun 15, 2025
This is a follow up to youtube#4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. youtube#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while youtube#4464 is being worked on. Bug: b/384819454
briantting
pushed a commit
that referenced
this pull request
Jul 1, 2025
Add script that calculates test targets based on gn deps is added to the build step. The output from this script is then passed through the build pipeline to each of the steps that use the list. b/382508397 original-hexsha: 292be22
briantting
pushed a commit
that referenced
this pull request
Jul 1, 2025
briantting
pushed a commit
that referenced
this pull request
Jul 1, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
briantting
pushed a commit
that referenced
this pull request
Jul 11, 2025
Add script that calculates test targets based on gn deps is added to the build step. The output from this script is then passed through the build pipeline to each of the steps that use the list. b/382508397 original-hexsha: 292be22
briantting
pushed a commit
that referenced
this pull request
Jul 11, 2025
briantting
pushed a commit
that referenced
this pull request
Jul 11, 2025
This is a follow up to #4831 which landed with a TODO to move the newly introduced `starboard_unittests` into a `if (current_toolchain == starboard_toolchain)` block, and let external users depend on a `starboard_unittests_wrapper` instead. #4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on. Bug: b/384819454 original-hexsha: bdaba2e
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 25, 2025
Add script that calculates test targets based on gn deps is added to the build step. The output from this script is then passed through the build pipeline to each of the steps that use the list. b/382508397 original-hexsha: 292be22
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 25, 2025
Partial revert of youtube#4464, as it currently doesn't reliably find all changed tests. Also - dynamic calculation should always be bypassed for post-submits b/382508397 original-hexsha: a32c619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add script that calculates test targets based on gn deps is added to the build step. The output from this script is then passed through the build pipeline to each of the steps that use the list.
b/382508397