Repository navigation
Commit 82430e3
authored
starboard: roll up the remaining unittest targets (#5127)
This PR continues the work of #4831 and rolls up all other targets I
could find that looked like unit tests into `starboard_unittests`.
With this I see
```
[==========] 1454 tests from 55 test suites ran. (8612 ms total)
[ PASSED ] 989 tests.
[ SKIPPED ] 465 tests, listed below:
...
YOU HAVE 1 DISABLED TEST
```
(the disabled test was from before, the skipped ones are new, see
further below).
Media-related topics:
- A number of tetst (e.g. `AudioDecoderTest` and others) needed a number
of system libraries to support codecs like AAC, AC3 etc but those are
part of non-free Debian repos, so couldn't install those in Docker. This
CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test
cases related to those codecs, when the build flag
`SKIP_PROPRIETARY_CODEC_TESTS` is present.
- `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to
X11 use not being torn down correctly; they need `xvfb-run`. This makes
me think those are not pure unit-tests but integration tests like
`nplb`. For the time being they are commented out with a TODO.
- `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s,
so I added it as extern.
- `FileCacheReader` needs to find the media files under the output
folder's `content/` directory. Files are under the output folder's
`starboard/content`, because of the starboard toolchain. This CL leaves
a quick hack and a TODO() to find a proper solution.
Finally:
- `//starboard/raspi/shared/:starboard_platform_tests` target was empty,
this CL removes it.
Bug: b/3848194541 parent 24999ce commit 82430e3
17 files changed
Lines changed: 130 additions & 52 deletions
File tree
- starboard
- contrib/cast/cast_starboard_api/samples
- loader_app
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
300 | | - | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
301 | 307 | | |
302 | 308 | | |
303 | 309 | | |
| |||
308 | 314 | | |
309 | 315 | | |
310 | 316 | | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
311 | 334 | | |
312 | 335 | | |
313 | 336 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
373 | | - | |
| 373 | + | |
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | | - | |
378 | 377 | | |
379 | 378 | | |
380 | 379 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
327 | 327 | | |
328 | 328 | | |
329 | 329 | | |
330 | | - | |
| 330 | + | |
331 | 331 | | |
332 | 332 | | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
337 | 342 | | |
338 | 343 | | |
339 | 344 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
82 | 85 | | |
83 | 86 | | |
84 | 87 | | |
| |||
92 | 95 | | |
93 | 96 | | |
94 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
95 | 101 | | |
96 | 102 | | |
97 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
253 | 253 | | |
254 | 254 | | |
255 | 255 | | |
256 | | - | |
| 256 | + | |
257 | 257 | | |
258 | 258 | | |
259 | | - | |
260 | 259 | | |
261 | 260 | | |
262 | 261 | | |
| |||
299 | 298 | | |
300 | 299 | | |
301 | 300 | | |
302 | | - | |
| 301 | + | |
303 | 302 | | |
304 | 303 | | |
305 | 304 | | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
| 305 | + | |
310 | 306 | | |
311 | 307 | | |
312 | 308 | | |
| |||
354 | 350 | | |
355 | 351 | | |
356 | 352 | | |
357 | | - | |
| 353 | + | |
358 | 354 | | |
359 | | - | |
360 | | - | |
361 | | - | |
362 | | - | |
| 355 | + | |
363 | 356 | | |
364 | 357 | | |
365 | 358 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
201 | | - | |
| 201 | + | |
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
445 | 453 | | |
446 | 454 | | |
447 | 455 | | |
| |||
0 commit comments