This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Bug fixes and performance improvements#169
Merged
Bnyro merged 6 commits intoyou-apps:mainfrom Jul 29, 2023
SuhasDissa:papomans
Merged
Bug fixes and performance improvements#169Bnyro merged 6 commits intoyou-apps:mainfrom SuhasDissa:papomans
Bnyro merged 6 commits intoyou-apps:mainfrom
SuhasDissa:papomans
Conversation
# Conflicts: # app/src/main/java/com/bnyro/recorder/ui/components/PlayerView.kt
Bnyro
reviewed
Jul 29, 2023
Member
|
Only some minor suggestions, looks great in general! Thanks! <3 |
Bnyro
approved these changes
Jul 29, 2023
Member
|
Thank you! <3 |
SuhasDissa
commented
Jul 30, 2023
| loadFiles() | ||
| return@launch | ||
| } | ||
| fileRepository.deleteSelectedFiles(selectedFiles.map { it.recordingFile }) |
Member
Author
There was a problem hiding this comment.
Found an issue in my code.
I forgot to clear the selectedFiles list after deleting the selected files.
Steps to reproduce bug
- Select a few Items and delete them
- After the deletion is complete, click the delete all button
- Nothing happens
Delete all button only works when there are no items selected (when the selectedFiles is empty).
But in here since I forgot to clear the list, the delete all button does not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some Bug fixes and performance improvements related to the Recording Items Screen
Bug Fixes
Performance Improvements
Other Changes
Footnotes
This bug exists in the latest release. Occurs when there are more than 5(approx.) recording items. ↩
This bug exists in the latest release. Sorting the items by size doesn't seem do anything. ↩
Fixed the UI freezing when deleting files ↩