Skip to content

Patch #909 to not fail CI#917

Merged
brentleyjones merged 4 commits intoyonaskolb:app-clipsfrom
dflems:dflems/20200728-clip
Jul 29, 2020
Merged

Patch #909 to not fail CI#917
brentleyjones merged 4 commits intoyonaskolb:app-clipsfrom
dflems:dflems/20200728-clip

Conversation

@dflems
Copy link
Contributor

@dflems dflems commented Jul 29, 2020 •
edited
Loading

  • Pull app clips out of TestProject/project.yml
  • Move to TestProject/project-xcode-12.yml
  • Generate new fixtures
  • Update build script to selectively build Xcode 12 project based on selected xcode version

Xcodegen itself can't build with Xcode 12 yet due to the Spectre dependency not building:

[44/69] Compiling JSONUtilities URL+JSONPrimitiveConvertible.swift
/Users/runner/work/XcodeGen/XcodeGen/.build/checkouts/Spectre/Sources/Spectre/XCTest.swift:35:14: error: 'recordFailure(withDescription:inFile:atLine:expected:)' is only available in macOS 10.13 or newer
    testCase.recordFailure(withDescription: "\(name): \(failure.reason)", inFile: failure.file, atLine: failure.line, expected: false)

brentleyjones
brentleyjones reviewed Jul 29, 2020
View reviewed changes
@dflems dflems force-pushed the dflems/20200728-clip branch from d108fef to f20304d Compare July 29, 2020 15:22
@dflems
Copy link
Contributor Author

dflems commented Jul 29, 2020

@brentleyjones Updated. Unfortunately, there's an issue with Spectre preventing Xcodegen from building with Xcode 12 at the moment, so I removed that entry from ci.yaml

@dflems dflems changed the title Patch #909 to build with Xcode 11 or Xcode 12 beta Patch #909 to not fail CI Jul 29, 2020
@brentleyjones brentleyjones merged this pull request into yonaskolb:app-clips Jul 29, 2020
@brentleyjones
Copy link
Collaborator

brentleyjones commented Jul 29, 2020

Thanks @dflems!

@dflems dflems deleted the dflems/20200728-clip branch July 29, 2020 18:50
brentleyjones pushed a commit that referenced this pull request Jul 29, 2020
@dflems @brentleyjones
Patch #909 to not fail CI (#917)
92527e2
brentleyjones pushed a commit that referenced this pull request Aug 13, 2020
@dflems @brentleyjones
Patch #909 to not fail CI (#917)
ab1a6cb
yonaskolb pushed a commit that referenced this pull request Aug 16, 2020
@brentleyjones @dflems
Add support for App Clips (#909)
bc51191 
* Add support for App Clips

Embeds App Clips into the containing app when they are a dependency.

* Patch #909 to not fail CI (#917)

Co-authored-by: Dan Fleming <[email protected]>
@dflems dflems mentioned this pull request Aug 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dflems @brentleyjones