Runs pre-gen command before validating project#1500
Merged
yonaskolb merged 1 commit intoyonaskolb:masterfrom Sep 12, 2024
Merged
Runs pre-gen command before validating project#1500yonaskolb merged 1 commit intoyonaskolb:masterfrom
yonaskolb merged 1 commit intoyonaskolb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the order of operations in the
generatecommand to run the pre-gen command before project validation.When running the
generatecommand, the validation step fails if a target'ssourceslist contains directories that don't exist yet. This is an issue when these directories are meant to be created by a pre-gen command.Consider the following project specification:
The pre-gen command generates Swift source files into the GeneratedSources folder, which is in .gitignore. Without the changes in this PR, running
generateresults in an error:With the changes in this PR, the pre-gen command is executed before the project is validated, meaning that
GeneratedSourcesis present during validation. This prevents the error and causes project generation to succeed.