Test action macroExpansion allows unavailable buildable reference.#1471
Merged
yonaskolb merged 3 commits intoyonaskolb:masterfrom Jul 3, 2024
Merged
Conversation
yonaskolb
reviewed
May 17, 2024
Owner
yonaskolb
left a comment
yonaskolb
left a comment
There was a problem hiding this comment.
Would you be able to add a test capturing this in https://github.com/yonaskolb/XcodeGen/blob/master/Tests/XcodeGenKitTests/SchemeGeneratorTests.swift
Contributor
Author
|
done! |
yonaskolb
approved these changes
Jul 3, 2024
Owner
yonaskolb
left a comment
yonaskolb
left a comment
There was a problem hiding this comment.
Fantastic, thank you @erneestoc!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #1468
Since the buildableReference passed to the test action macroExpansion param is literally the first buildable reference, there's a chance that buildable reference is not part of the test buildable references, so "Expand Variables Based On" defaults to None (for the test action)
A potential solution is to use the first buildable reference from
testBuildTargetEntriesinstead if the buildableReference is not part of (testBuildTargetEntries).