Allow changing macro expansions on test actions.#1468
Allow changing macro expansions on test actions.#1468yonaskolb merged 7 commits intoyonaskolb:masterfrom
Conversation
|
So basically, I'm trying to achieve a scheme where I can:
It seems to work for the most part except I'm losing my test macroExpansions. The problem is that I'm relying on my tests to be able to expand macros to find some files. When setting up a scheme like this, the action will pick up the first buildable reference it finds, and sometimes, for some reason, none. So, I would like to explicitly define which buildable reference to use for the test macro expansion. One potential solution is to avoid relying on |
|
Maybe this instead? #1471 |
yonaskolb
left a comment
yonaskolb
left a comment
There was a problem hiding this comment.
Happy to have both this and the other PR too. Better defaults with the ability to override 👍
yonaskolb
left a comment
yonaskolb
left a comment
There was a problem hiding this comment.
Great, we can merge this after the merge conflict 👍
|
@yonaskolb I had some conflicting logic with the previous PR I had to fix - if you can give it another check 🙏🏻 |
| customLLDBInit = jsonDictionary.json(atKeyPath: "customLLDBInit") | ||
| captureScreenshotsAutomatically = jsonDictionary.json(atKeyPath: "captureScreenshotsAutomatically") ?? Scheme.Test.captureScreenshotsAutomaticallyDefault | ||
| deleteScreenshotsWhenEachTestSucceeds = jsonDictionary.json(atKeyPath: "deleteScreenshotsWhenEachTestSucceeds") ?? Scheme.Test.deleteScreenshotsWhenEachTestSucceedsDefault | ||
| macroExpansion = jsonDictionary.json(atKeyPath: "macroExpansion") |
There was a problem hiding this comment.
Sorry, just missing the encoding in toJSONValue below as well
2 participants
There are cases where it's useful to specify an alternate target as macro expansion for tests instead of the default which it's currently the first buildable reference.