-
Notifications
You must be signed in to change notification settings - Fork 870
Support Artifact Bundle #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Artifact Bundle #1388
Changes from all commits
d55fcb6
e3ac5e0
b0b6a93
4a02f37
019ccc0
2ed1bee
512ec95
5fa61af
1a42ba2
deef7e7
b98231e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,5 @@ xcuserdata | |
| *.xcuserstate | ||
| XcodeGen.xcodeproj | ||
| xcodegen.zip | ||
| xcodegen.artifactbundle.zip | ||
| .vscode/launch.json | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| # Change Log | ||
|
|
||
| ## Next Version | ||
| ### Added | ||
|
|
||
| - Support Artifact Bundle #1388 @freddi-kit | ||
|
|
||
| ### Fixed | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../SettingPresets/ | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this file do?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is symbolic link for SeetingPresets in root to detect it as bundle file for XcodeGenKit. Package.swift cannot find it if we don't have it in root of target source file here https://github.com/yonaskolb/XcodeGen/pull/1388/files#diff-f913940c58e8744a2af1c68b909bb6383e49007e6c5a12fb03104a9006ae677eR46 We also cannot set it as .copy("../../SettingPresets") |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -202,6 +202,9 @@ extension SettingsPresetFile { | |
| symlink.parent() + relativePath, | ||
| ] + possibleSettingsPaths | ||
| } | ||
| if let moduleResourcePath = Bundle.module.path(forResource: "SettingPresets", ofType: nil) { | ||
| possibleSettingsPaths.append(Path(moduleResourcePath) + "\(path).yml") | ||
| } | ||
|
Comment on lines
+205
to
+207
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @roman-aliyev If @yonaskolb agree with your way, please open PR and do not forget to add this code and copy script SettingPresets to bundle.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, please add https://github.com/yonaskolb/XcodeGen/pull/1388/files#diff-f913940c58e8744a2af1c68b909bb6383e49007e6c5a12fb03104a9006ae677eR45-R46 and make symbolic link as https://github.com/yonaskolb/XcodeGen/pull/1388/files#diff-9f320f241fc06216ac0b9fed9a549298a11c8f203c299350159cab6946344b14 |
||
|
|
||
| guard let settingsPath = possibleSettingsPaths.first(where: { $0.exists }) else { | ||
| switch self { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.