-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variations in combination with comments #260
Comments
There are two things here. First of all, the fact that parser erases the text comment "French, I thought he would play Carokann" is a bug. This comment has to be rendered in some way. This is a bug. But on the other hand, putting a text comment just between the end of a sub-variation (i.e.
For instance, with
... Hence, in your example, the expected output is: 1.e4 e6 French, I thought he would play Carokann , but fortunately I like French too (1…c6) 2.d4 d5 and white wins This is what you will obtain with version 7.5.1 (just released). But considering the meaning of the text comments in this particular example, I would suggest instead to write them as:
|
Thanx for fixing the bug. I can live with the way you implemented it. Some clubmembers are generating pgn via all kind of of (online) programs. Before publishing we have to check the way it looks on the website of the club. No problem and thanx again! |
I really like the fact that this plugin tries to follow pgn as strict as possible!
It looks like the interpreter has some problems when both a variation and some comments are placed between two moves:
[pgn]
1.e4 e6 {French, I thought he would play Carokann} (1...c6){, but fortunately I like French too} 2.d4 d5 {and white wins}*
[/pgn]
has as a result:
1.e4 e6, but fortunately I like French too (1…c6) 2.d4 d5 and white wins
Since this looks like straightforward pgn, I hope you have a solution for this behaviour
The text was updated successfully, but these errors were encountered: