Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 minor bugs #25

Closed
buffos opened this issue Nov 23, 2014 · 8 comments
Closed

2 minor bugs #25

buffos opened this issue Nov 23, 2014 · 8 comments
Labels

Comments

@buffos
Copy link

buffos commented Nov 23, 2014

  1. if the fen position does not have pieces down a file, than the file collapses (it does not happen in boards in pgn

for example use 2r1kb1r/pp4pp/2n1p3/1B2N3/5KbB/P4P2/1P5P/2R4R b k - 0 1

and you will see it breaking along the d file

  1. The square_size does not work if you select the pop_up navigation board

Besides those 2 the plugin is really great (and beatiful , which is very important).

to be exact , the second one is not a bug . probably its a decision.

@yo35
Copy link
Owner

yo35 commented Nov 23, 2014

Hi,

Thanks for your report and for your enthusiasm! Now, I have a few remarks and questions about your points:

About 1). Could you give some additional details on the situation in which you encounter this "file collapse" bug? In particular, it might be helpful to know which browser you are using, and maybe an example of a website for which the problem happens. I've tried to reproduced your example on this page: http://yo35.org/rpb-chessboard/tests/, however the position appears to be OK for me.

About 2). This is indeed a decision. The square size parameter in the popup frame is controlled by the global settings of the plugin, and cannot be overridden locally with the options passed to the [pgn][/pgn] tags. One reason for this is that if there are several PGN games in a page, they all share the same popup frame: therefore, if each of them defines a different square size for the navigation board in the popup, this would ends up with a weird behavior.

@buffos
Copy link
Author

buffos commented Nov 23, 2014

Hi

I am using a localhost installation , latest wordpress, using Xampp as an apache server. Nothing special. To "fix" the issue on my side, i just added a min-width. So this was not a big problem (although weird)
Using chrome and i see your demo fine.

I wonder why i have the server crashing. Do you parse pgn through php? What PHP version? Here its 5.5.15

@yo35
Copy link
Owner

yo35 commented Nov 23, 2014

This is weird. Maybe a clash with the theme you are using? or with some CSS brought by another plugin?

@buffos
Copy link
Author

buffos commented Nov 23, 2014

  1. I just found out that the width problem is caused when the board is contained in a div element that is "smaller" than the board. Then it will collapse any such file. I will find a solution to that (and inform you ofcourse)
  2. The second problem (crash) cannot be something else. I have a small comment, it works fine.
    I paste a big one, i get an error message that xampp has force-closed on an error.

@buffos
Copy link
Author

buffos commented Nov 23, 2014

For now my solution to (1) is (when i use for example a 60px wide cell). So its not a big deal.

.uichess-chessboard-cell {
min-width: 60px;
min-height: 60px;
}

@yo35
Copy link
Owner

yo35 commented Nov 23, 2014

Setting the height of the cell with min-height instead of height makes the empty rows collapse.

@buffos
Copy link
Author

buffos commented Nov 23, 2014

I am not replacing them. height still exists. I am just creating an additional rule. I don't have problems with empty rows after addind this rule in my stylesheet.

@yo35 yo35 added the bug label Nov 23, 2014
@yo35
Copy link
Owner

yo35 commented Nov 23, 2014

Bug (1) is fixed in version 3.4.2. As (2) is not a bug, I close the thread.

@yo35 yo35 closed this as completed Nov 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants