Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jquery wasn't generated in my custom template #154

Closed
estruth opened this issue May 12, 2019 · 2 comments
Closed

jquery wasn't generated in my custom template #154

estruth opened this issue May 12, 2019 · 2 comments
Labels
bug

Comments

@estruth
Copy link

estruth commented May 12, 2019

dear sirs please look at my homepage with a own template. The url is
https://www.schachklub-wiehre.de/ralfs-taktische-meisterleistung/
all srcipts with jquery wasn't generated as on your site as

<script src='https://rpb-chessboard.yo35.org/wp-includes/js/jquery/jquery.js?ver=1.12.4'></script>

Why? Thanks in advance. best regards edi
@yo35
Copy link
Owner

yo35 commented May 13, 2019

Hi.
This problem comes from the fact that your theme does not include jQuery by default (which is rightful). The plugin wrongly assumes that jQuery is already included when trying to render the chessboard/chessgames.

To cut a long story short, this is a bug of the plugin, I have to fix it.

@yo35 yo35 added the bug label May 13, 2019
yo35 added a commit that referenced this issue May 13, 2019
@yo35
Always enqueue jQuery in frontend (#154)
681a7d3
@yo35
Copy link
Owner

yo35 commented May 13, 2019

Fixed in plugin version 5.6.2 (just released).

@yo35 yo35 closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yo35 @estruth