-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Castling and Black Moves #142
Comments
Hi,
I'm not sure it is a good idea to make the parser tolerant to this kind of errors in the PGN, as it would introduce some additional complexity to it, meaning additional maintenance effort, possibly more bugs. The question is: how these faulty PGN files have been generated?
|
I should have been more specific - the malformed parts are in the respective comments sections (i.e. within curly brackets).
I understand completely that it may not be a good idea to support non-standard/non-compliant PGNs. I wanted to bring it up anyways (in particular since Chessbase is very commonly used), but pls feel free to close this Issue as Won't Fix |
Hi, Chessbase PGN viewer behaves in weird manner regarding these issues: from what I guess, it renders castling moves with the Definitively, I prefer not to allow these syntaxes, as the PGN standard is pretty clear on what is expected to be the correct syntax on these topics. If such an ill-formed PGN file is submitted to the RPB Chessboard, an error is displayed to the user highlighting what he/she must fix. And even if there are a large number of such errors in the file, automatic text replacement can be applied to fix them all at once. |
It appears that the FIDE handbook recommends to use character Since this convention appears in an official normalization document, and since I received several queries regarding the support of zero-encoded castling moves, I changed my mind, and I will make RPB Chessboard support that. |
Fixed in version 6.2.1 |
For whatever reason, some PGN files tolerate 0-0 (instead of O-O) for castling and say 10....Qd4 (instead of 10...Qd4) for black moves. See, for example, some of the games at https://www.hsk1830.de/pages/mannschaften/17-18/bundesligen/berichte/hsk1/Bl-Haeppchen_1718.htm - this site uses the Chessbase PGN viewer (and probably chessbase-generated PGN files, not sure).
For castling, the PGN standard is pretty clear (http://www.saremba.de/chessgml/standards/pgn/pgn-complete.htm#c8.2.3), don't know for black moves. Either way, when using such PGNs, I get parsing errors in the RPB Chessboard, and I have to fix them manually. So my question is, could the parser be a bit more fault-tolerant?
The text was updated successfully, but these errors were encountered: