Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page jumps on iPad / iPhone #129

Closed
richiwalt opened this issue Apr 8, 2018 · 8 comments
Closed

Page jumps on iPad / iPhone #129

richiwalt opened this issue Apr 8, 2018 · 8 comments
Labels

Comments

@richiwalt
Copy link

The behavior is slightly different ... but the main problem remains on my site. I’ve commented on the original ticket with details. This post may be deleted if those comments are seen.

Thanks

Richard.

@yo35
Copy link
Owner

yo35 commented Apr 8, 2018

Hi Richard,
In the comments of #128, you've mentioned "Looks like it is trying to make the mouse clicked move be at the very top of the page". The actual behavior -- in the popup frame mode -- is that the plugins tries to scroll the page so that the selected move is visible. This is the behavior requested in #28.

I've just re-tested this feature, and it looks mostly OK for me: if the selected moved is already visible, no scrolling happens. Scrolling towards the bottom of the page is also OK. Only scrolling towards the top of the page may not take into account the admin bar thickness, but I think this is a rather minor issue.

Then, without accessing to your website, I cannot guess what is wrong. May be there is something specific due to your theme, maybe something else.

@richiwalt
Copy link
Author

richiwalt commented Apr 8, 2018 via email

@yo35
Copy link
Owner

yo35 commented Apr 8, 2018

Hi Richard,

I've tried on Chrome on Android, everything seems to be fine.

This problem you encounter on iPad, have you observed it with any browser? Or just with the default browser, which I guess is Safari?

@richiwalt
Copy link
Author

richiwalt commented Apr 8, 2018 via email

@yo35 yo35 changed the title Perhaps bug #128 was closed prematurely Page jumps on iPad / iPhone Apr 21, 2018
@yo35 yo35 added the bug label Apr 21, 2018
@sabapathee
Copy link

sabapathee commented Apr 25, 2018

Hi,
I have the same issue on iPhone (or iPad) with iOS11.3 (with Safari and Chrome) when I use the navigation bar to view the next moves, the screen jumps to the top (or bottom).
On desktop, it is OK I don’t have the issue when I use the responsive mode in Google Chrome or Safari.
Here is the site: https://wordpress.project-toolbox.fr/test-rpb-chessboard/
(I use RPB Chessboard plugin version 5.2.1)

@yo35
Copy link
Owner

yo35 commented May 1, 2018

Hi all,
Since I don't have any iOS device, I'll need your help to validate a bugfix.

Could you have a look to the following page, and tell me whether it behaves as expected or not on an iPhone or an iPad:
https://rpb-chessboard.yo35.org/temporary-simple-chess-game-within-a-long-page/

If OK, I will release a new version of the plugin including the bugfix.

@sabapathee
Copy link

Hi,
It works as expected !
I will update the new version as soon as it will available.
Thanks

yo35 added a commit that referenced this issue May 1, 2018
@yo35
Copy link
Owner

yo35 commented May 1, 2018

Fix in version 5.2.2 (just released).
Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants