Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AJAX: Don't write to filesystem #118

Closed
paulschreiber opened this issue Feb 23, 2018 · 3 comments
Closed

AJAX: Don't write to filesystem #118

paulschreiber opened this issue Feb 23, 2018 · 3 comments

Comments

@paulschreiber
Copy link
Contributor

WordPress VIP support will not allow this plugin to be used until this issue is addressed:

models/ajax/removepiecesetsprite.php

Line 43, file system writes are forbidden.
@paulschreiber
Copy link
Contributor Author

It looks like this file/class is never used. Is that correct? Can it be removed?

@yo35
Copy link
Owner

yo35 commented Mar 11, 2018

This class is used to implement an AJAX call, which is related to the process I've just described in #117.

Basically, when an attachment is removed, if it has been used to generate a sprite image as described in #117, then the sprite image must be removed as well. This is what is done by the function run() in this class.

@yo35
Copy link
Owner

yo35 commented Apr 1, 2018

The class models/ajax/removepiecesetsprite.php has been removed with the refactoring achieved for #117.

@yo35 yo35 closed this as completed Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulschreiber @yo35