Skip to content

Copy Command ignores the vcs ignored files if those are present in build.include #21

@selul

Description

@selul

Considering the following file structure and contents.

.gitignore

web/app/themes/*/
!web/app/themes/theme
node_modules

ymir.yml

...
    build:
      include:
        - web/app/themes/theme

When the copy is being done, if the theme folder has a node_modules folder, this is being added to the deployment, despite the fact the folder is being ignored on .gitignore.

I think this is happening because we include the build.include on the last step. https://github.com/ymirapp/cli/blob/main/src/Build/CopyWordPressFilesStep.php which copy over the gitignored files.

A possible solution that I see is to apply the $finder->ignoreVCSIgnored(true); at the very end.

This is currently causing the copy of thousands of node_modules files to s3.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions