fix: tweak finder rules

carlalexander · carlalexander · commit f35b5c247001 · 2020-11-30T13:49:35.000-05:00
diff --git a/src/Build/CompressBuildFilesStep.php b/src/Build/CompressBuildFilesStep.php
@@ -91,8 +91,7 @@ private function getPhpFiles(): Finder
         return Finder::create()
             ->in($this->buildDirectory)
             ->files()
-            ->name(['*.php'])
-            ->ignoreVCS(true);
+            ->name(['*.php']);
     }
 
     /**
@@ -109,8 +108,6 @@ private function getWordPressCoreFiles(string $projectType): Finder
 
                 return sprintf('/^%s/', $path);
             })->add('/^bin\//')->all())
-            ->files()
-            ->ignoreVCS(true)
-            ->ignoreDotFiles(false);
+            ->files();
     }
 }
diff --git a/src/Build/CopyWordPressFilesStep.php b/src/Build/CopyWordPressFilesStep.php
@@ -125,11 +125,8 @@ private function getProjectFiles(string $projectType): Finder
     {
         $finder = Finder::create()
             ->in($this->projectDirectory)
-            ->exclude(['.idea', '.ymir'])
             ->notName(['ymir.yml'])
-            ->followLinks()
-            ->ignoreVcs(true)
-            ->ignoreDotFiles(false);
+            ->followLinks();
 
         if (is_readable($this->projectDirectory.'/.gitignore')) {
             $finder->ignoreVCSIgnored(true);
diff --git a/src/Build/ExtractAssetFilesStep.php b/src/Build/ExtractAssetFilesStep.php
@@ -91,7 +91,6 @@ private function getAssetFiles(string $fromDirectory): Finder
             ->files()
             ->notName(['*.php'])
             ->followLinks()
-            ->ignoreVcs(true)
             ->ignoreDotFiles(true);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,7 @@ private function getPhpFiles(): Finder`
`91`	`91`	`return Finder::create()`
`92`	`92`	`->in($this->buildDirectory)`
`93`	`93`	`->files()`
`94`		`- ->name(['*.php'])`
`95`		`- ->ignoreVCS(true);`
	`94`	`+ ->name(['*.php']);`
`96`	`95`	`}`
`97`	`96`
`98`	`97`	`/**`
`@@ -109,8 +108,6 @@ private function getWordPressCoreFiles(string $projectType): Finder`
`109`	`108`
`110`	`109`	`return sprintf('/^%s/', $path);`
`111`	`110`	`})->add('/^bin\//')->all())`
`112`		`- ->files()`
`113`		`- ->ignoreVCS(true)`
`114`		`- ->ignoreDotFiles(false);`
	`111`	`+ ->files();`
`115`	`112`	`}`
`116`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,6 @@ private function getAssetFiles(string $fromDirectory): Finder`
`91`	`91`	`->files()`
`92`	`92`	`->notName(['*.php'])`
`93`	`93`	`->followLinks()`
`94`		`- ->ignoreVcs(true)`
`95`	`94`	`->ignoreDotFiles(true);`
`96`	`95`	`}`
`97`	`96`