feat: use same default size option value for local and ftp import

carlalexander · carlalexander · commit 3fc79b90f03e · 2022-07-10T20:12:31.000-04:00
diff --git a/src/Command/Uploads/ImportUploadsCommand.php b/src/Command/Uploads/ImportUploadsCommand.php
@@ -73,7 +73,7 @@ protected function configure()
             ->addArgument('path', InputArgument::OPTIONAL, 'The path to the files to import')
             ->addOption('environment', null, InputOption::VALUE_REQUIRED, 'The environment to upload files to', 'staging')
             ->addOption('force', null, InputOption::VALUE_NONE, 'Force the import to run')
-            ->addOption('size', null, InputOption::VALUE_REQUIRED, 'The number of files to process at a time');
+            ->addOption('size', null, InputOption::VALUE_REQUIRED, 'The number of files to process at a time', 1000);
     }
 
     /**
@@ -95,12 +95,6 @@ protected function perform(InputInterface $input, OutputInterface $output)
         $filesystem = new Filesystem($adapter);
         $size = $this->getNumericOption($input, 'size');
 
-        if (null === $size && $adapter instanceof LocalFilesystemAdapter) {
-            $size = 1000;
-        } elseif (null === $size) {
-            $size = 100;
-        }
-
         if ($size < 1) {
             throw new InvalidArgumentException('Cannot have a "size" smaller than 1');
         }
@@ -117,6 +111,10 @@ protected function perform(InputInterface $input, OutputInterface $output)
         $total = 0;
         $progressBar->setMessage((string) $total, 'total');
 
+        if (!$adapter instanceof LocalFilesystemAdapter) {
+            $output->infoWithWarning('Scanning remote "uploads" directory', 'takes a few seconds');
+        }
+
         $requests = LazyCollection::make(function () use ($filesystem) {
             $files = $filesystem->listContents('', Filesystem::LIST_DEEP)->filter(function (StorageAttributes $attributes) {
                 return $attributes->isFile();
