fix: add errors if trying to interact with databases on a private server

carlalexander · carlalexander · commit 37f38a9afc55 · 2022-02-01T10:40:02.000-05:00
diff --git a/src/Command/Database/CreateDatabaseCommand.php b/src/Command/Database/CreateDatabaseCommand.php
@@ -13,6 +13,7 @@
 
 namespace Ymir\Cli\Command\Database;
 
+use Symfony\Component\Console\Exception\RuntimeException;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -45,6 +46,11 @@ protected function configure()
     protected function perform(InputInterface $input, OutputInterface $output)
     {
         $databaseServer = $this->determineDatabaseServer('On which database server would you like to create the new database?', $input, $output);
+
+        if (!$databaseServer['publicly_accessible']) {
+            throw new RuntimeException('Database on private database servers need to be manually created.');
+        }
+
         $name = $this->getStringArgument($input, 'name');
 
         if (empty($name)) {
diff --git a/src/Command/Database/ListDatabasesCommand.php b/src/Command/Database/ListDatabasesCommand.php
@@ -13,6 +13,7 @@
 
 namespace Ymir\Cli\Command\Database;
 
+use Symfony\Component\Console\Exception\RuntimeException;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Ymir\Cli\Console\OutputInterface;
@@ -42,9 +43,15 @@ protected function configure()
      */
     protected function perform(InputInterface $input, OutputInterface $output)
     {
+        $databaseServer = $this->determineDatabaseServer('Which database server would you like to list databases from', $input, $output);
+
+        if (!$databaseServer['publicly_accessible']) {
+            throw new RuntimeException('Database on private database servers cannot be listed.');
+        }
+
         $output->table(
             ['Name'],
-            $this->apiClient->getDatabases($this->determineDatabaseServer('Which database server would you like to list databases from', $input, $output)['id'])->map(function (string $name) {
+            $this->apiClient->getDatabases($databaseServer['id'])->map(function (string $name) {
                 return [$name];
             })->all()
         );
