Skip to content

Add gymnasium option#24

Merged
ymd-h merged 1 commit intoymd-h:masterfrom
jamartinh:gymnasium
Mar 21, 2023
Merged

Add gymnasium option#24
ymd-h merged 1 commit intoymd-h:masterfrom
jamartinh:gymnasium

Conversation

@jamartinh
Copy link
Copy Markdown
Contributor

@jamartinh jamartinh commented Mar 20, 2023

Just modify util.py to allow upgrading to gymnasium

try:
    from gymnasium.spaces import Discrete, MultiDiscrete, Box, MultiBinary, Tuple, Dict
except ImportError:
    from gym.spaces import Discrete, MultiDiscrete, Box, MultiBinary, Tuple, Dict

@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Mar 20, 2023

You have successfully added a new Pmd (reported by Codacy) configuration .github/workflows/codacy-analysis.yaml:codacy-security-scan. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2023
View reviewed changes
cpprb/util.py
from gym.spaces import Discrete, MultiDiscrete, Box, MultiBinary, Tuple, Dict


def from_space(space, int_type, float_type):

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

Missing function or method docstring

Missing function or method docstring
@ymd-h
Copy link
Copy Markdown
Owner

ymd-h commented Mar 20, 2023

@jamartinh
Thank you for your PR!

I think this PR is fine.
(It seems that CI failures come from using deprecated version/API)

I will merge it.

@ymd-h ymd-h merged commit f43fb19 into ymd-h:master Mar 21, 2023
@ymd-h
Copy link
Copy Markdown
Owner

ymd-h commented Mar 23, 2023

@jamartinh

Finally, this was released as a part of v10.7.0.
Thank you for your great support!

https://github.com/ymd-h/cpprb/tree/v10.7.0
https://pypi.org/project/cpprb/10.7.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamartinh @github-advanced-security @ymd-h