Fix Type Declarations for ESModule#18
Merged
Merged
Conversation
Owner
|
Look. We have problems with import gulpEsbuild, {createGulpEsbuild} from "gulp-esbuild";
console.log(gulpEsbuild);
console.log(createGulpEsbuild);
console.log(gulpEsbuild.createGulpEsbuild);
import("gulp-esbuild")
.then(result => {
console.log('dynamic import');
console.log(result.createGulpEsbuild);
console.log(result.default);
console.log(result.default.createGulpEsbuild);
})Typescript uses Should |
Owner
|
I mean mts declaration file should looks like: import {Transform} from 'stream'
import {BuildOptions} from 'esbuild'
type Options = Omit<
BuildOptions,
'write' | 'incremental' | 'entryPoints' | 'stdin' | 'watch' | 'allowOverwrite' | 'absWorkingDir' | 'nodePaths'
> & {
metafileName?: string
}
interface CreateOptions {
incremental?: boolean
pipe?: boolean
}
type GulpEsbuild = (options: Options) => Transform
type CreateGulpEsbuild = (options: CreateOptions) => GulpEsbuild
declare const gulpEsbuild: GulpEsbuild;
declare const createGulpEsbuild: CreateGulpEsbuild
export {createGulpEsbuild}
export default gulpEsbuildWithout |
Contributor
Author
|
Thanks, I totally missed that one |
Contributor
Author
|
Alright! Fixed it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in this PR will add type declarations for the ESModule version of this package.
In doing so, this PR will fix #17.