Skip to content

Improve psalm annotations in Result class#636

Merged
vjik merged 1 commit into
masterfrom
improve-psalm
Nov 22, 2023
Merged

Improve psalm annotations in Result class#636
vjik merged 1 commit into
masterfrom
improve-psalm

Conversation

@vjik

@vjik vjik commented Nov 22, 2023

Copy link
Copy Markdown
Member
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

@what-the-diff

what-the-diff Bot commented Nov 22, 2023

Copy link
Copy Markdown

PR Summary

  • Enhancement of 'Result' Class with Annotations
    This update introduces descriptive markers known as annotations to the Result class. This aims to offer clear and concise documentation within the code itself, improving its readability and maintainability.
  • CHANGELOG.md Updated to Reflect Recent Changes
    The update documentation (CHANGELOG.md) has been modified to include the latest enhancements to the Result class. This allows the team and users to quickly grasp the improvements in the new version.

@vjik vjik requested a review from a team November 22, 2023 07:53
@vjik vjik added the status:code review The pull request needs review. label Nov 22, 2023
@codecov

codecov Bot commented Nov 22, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (010ac44) 12.24% compared to head (4515e2c) 94.45%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #636       +/-   ##
=============================================
+ Coverage     12.24%   94.45%   +82.21%     
  Complexity      776      776               
=============================================
  Files            91       91               
  Lines          2361     2361               
=============================================
+ Hits            289     2230     +1941     
+ Misses         2072      131     -1941     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 8adee52 into master Nov 22, 2023
@vjik vjik deleted the improve-psalm branch November 22, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants