Skip to content

Fix CI#620

Merged
arogachev merged 12 commits into
masterfrom
fix-ci-2
Aug 18, 2023
Merged

Fix CI#620
arogachev merged 12 commits into
masterfrom
fix-ci-2

Conversation

@arogachev

Copy link
Copy Markdown
Contributor
Q A
Is bugfix?
New feature?
Breaks BC?

@arogachev arogachev added the type:task Task label Aug 15, 2023
@arogachev arogachev self-assigned this Aug 15, 2023
@what-the-diff

what-the-diff Bot commented Aug 15, 2023

Copy link
Copy Markdown

PR Summary

  • Removed a Specific Class from Skipped List
    The code update removes a certain processing step (AddDefaultValueForUndefinedVariableRector class) which was being skipped previously during the program's operation. This suggests the developers have now included this step in the process. As a result, the system could possibly become more efficient or have better error-handling capacity, as the specific class seems to be responsible for providing default values for variables that do not have any value assigned yet.

@codecov

codecov Bot commented Aug 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (def3a69) 94.30% compared to head (e78a007) 94.34%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #620      +/-   ##
============================================
+ Coverage     94.30%   94.34%   +0.04%     
- Complexity      749      756       +7     
============================================
  Files            88       88              
  Lines          2281     2300      +19     
============================================
+ Hits           2151     2170      +19     
  Misses          130      130              
Files Changed Coverage Δ
src/Rule/IpHandler.php 100.00% <ø> (ø)
src/Rule/AbstractNumber.php 100.00% <100.00%> (ø)
src/Rule/Email.php 100.00% <100.00%> (ø)
src/Rule/Regex.php 100.00% <100.00%> (ø)
src/Rule/Url.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev requested a review from a team August 16, 2023 07:53
@arogachev arogachev added the status:code review The pull request needs review. label Aug 16, 2023
@arogachev arogachev marked this pull request as ready for review August 16, 2023 07:53
Comment thread .github/workflows/bc.yml
@arogachev arogachev merged commit 58b6be6 into master Aug 18, 2023
@arogachev arogachev deleted the fix-ci-2 branch August 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review. type:task Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants