Skip to content

Add exception code and previous exception to package exceptions#470

Merged
samdark merged 1 commit into
masterfrom
exceptions
Dec 19, 2022
Merged

Add exception code and previous exception to package exceptions#470
samdark merged 1 commit into
masterfrom
exceptions

Conversation

@vjik
Copy link
Copy Markdown
Member

@vjik vjik commented Dec 18, 2022

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2022

Codecov Report

Base: 89.54% // Head: 89.51% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (55caced) compared to base (54ee3e0).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #470      +/-   ##
============================================
- Coverage     89.54%   89.51%   -0.04%     
  Complexity      710      710              
============================================
  Files            86       86              
  Lines          2277     2280       +3     
============================================
+ Hits           2039     2041       +2     
- Misses          238      239       +1     
Impacted Files Coverage Δ
src/Exception/UnexpectedRuleException.php 90.90% <75.00%> (-9.10%) ⬇️
...c/Exception/InvalidCallbackReturnTypeException.php 69.23% <100.00%> (ø)
...on/RuleHandlerInterfaceNotImplementedException.php 92.85% <100.00%> (ø)
src/Exception/RuleHandlerNotFoundException.php 90.90% <100.00%> (ø)
src/RuleHandlerResolver/RuleHandlerContainer.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik requested a review from a team December 18, 2022 08:40
@vjik vjik added the status:code review The pull request needs review. label Dec 18, 2022
@samdark samdark merged commit 6b89cc2 into master Dec 19, 2022
@samdark samdark deleted the exceptions branch December 19, 2022 06:52
@samdark
Copy link
Copy Markdown
Member

samdark commented Dec 19, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants