Skip to content

Add test environments#416

Merged
samdark merged 13 commits into
masterfrom
test-environments
Dec 4, 2022
Merged

Add test environments#416
samdark merged 13 commits into
masterfrom
test-environments

Conversation

@vjik

@vjik vjik commented Dec 2, 2022

Copy link
Copy Markdown
Member
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff

what-the-diff Bot commented Dec 2, 2022

Copy link
Copy Markdown
  • Added phpunit configs for different test environments
  • Refactored tests to use common container creation logic
  • Rename Php81 to TestEnvironments/Php81
  • Add test for intl message formatter config option
  • Added tests for default translator.
  • Fixed a bug in Url rule when enableIDN is set to true and intl extension is not available (throws an exception).
  • Fixed a bug in Email rule when enableIDN is set to true and intl extension is not available (throws an exception).

@codecov

codecov Bot commented Dec 2, 2022

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b95695a) compared to base (12811eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #416   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       644       644           
===========================================
  Files             77        77           
  Lines           1530      1531    +1     
===========================================
+ Hits            1530      1531    +1     
Impacted Files Coverage Δ
config/common.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik marked this pull request as ready for review December 2, 2022 09:56
@vjik vjik requested a review from a team December 2, 2022 09:56
@vjik vjik added the status:code review The pull request needs review. label Dec 2, 2022
@samdark samdark merged commit 102bf2e into master Dec 4, 2022
@samdark samdark deleted the test-environments branch December 4, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants