Improve callable rule#343
Merged
Merged
Conversation
…ove-callable-rule # Conflicts: # src/Rule/Callback.php
Codecov ReportBase: 95.72% // Head: 95.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
============================================
- Coverage 95.72% 95.67% -0.06%
- Complexity 600 601 +1
============================================
Files 73 73
Lines 1428 1433 +5
============================================
+ Hits 1367 1371 +4
- Misses 61 62 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
vjik
requested changes
Oct 15, 2022
arogachev
reviewed
Oct 18, 2022
arogachev
reviewed
Oct 18, 2022
arogachev
reviewed
Oct 18, 2022
arogachev
reviewed
Oct 18, 2022
arogachev
reviewed
Oct 18, 2022
arogachev
reviewed
Oct 18, 2022
arogachev
reviewed
Oct 20, 2022
arogachev
approved these changes
Oct 20, 2022
arogachev
added a commit
that referenced
this pull request
Oct 20, 2022
* Fix rules serialization * Apply fixes from StyleCI * Add test for iterable rules * Fix error message * Apply fixes from StyleCI * Improve callable rule (#343) * Add ability to run non-static closures * Apply fixes from StyleCI * Fix tests * Apply fixes from StyleCI * Improve method check * Apply fixes from StyleCI * Check property before the use * Collapse test * Apply fixes from StyleCI * Add test for static method * Apply CR suggestions * Update tests/Rule/CallbackTest.php * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <[email protected]> Co-authored-by: Alexey Rogachev <[email protected]> * Fix code coverage Co-authored-by: StyleCI Bot <[email protected]> Co-authored-by: Alexey Rogachev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.