Fix stack cleanup and performance in MiddlewareDispatcher #37

devanych · 2021-07-15T07:17:24Z

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	-

roxblnfk

Good job!
But i also think that code will be better (a little more beautiful):

unset($this->stack);
$this->stack = null;

roxblnfk · 2021-07-15T07:58:29Z

Benches (php 8.0.7)

DispatcherBench is current dispatcher
BuilderBench is builder from #33

Before fix:

BuilderBench
+-----------------------+-----+------+-----+----------+-----------+--------+
| subject               | set | revs | its | mem_peak | mode      | rstdev |
+-----------------------+-----+------+-----+----------+-----------+--------+
| benchWith5Middleware  | 0   | 1000 | 10  | 1.097mb  | 64.775μs  | ±2.53% |
| benchWith25Middleware | 0   | 1000 | 10  | 1.125mb  | 274.827μs | ±1.78% |
| benchWith50Middleware | 0   | 1000 | 10  | 1.161mb  | 533.905μs | ±1.17% |
| benchWith75Middleware | 0   | 1000 | 10  | 1.196mb  | 822.834μs | ±2.17% |
+-----------------------+-----+------+-----+----------+-----------+--------+

DispatcherBench
+-----------------------+-----+------+-----+-----------+-----------+--------+
| subject               | set | revs | its | mem_peak  | mode      | rstdev |
+-----------------------+-----+------+-----+-----------+-----------+--------+
| benchWith5Middleware  | 0   | 1000 | 10  | 8.372mb   | 68.109μs  | ±1.92% |
| benchWith25Middleware | 0   | 1000 | 10  | 35.256mb  | 289.129μs | ±3.08% |
| benchWith50Middleware | 0   | 1000 | 10  | 69.087mb  | 563.296μs | ±1.24% |
| benchWith75Middleware | 0   | 1000 | 10  | 112.671mb | 840.167μs | ±2.19% |
+-----------------------+-----+------+-----+-----------+-----------+--------+

After fix:

BuilderBench
+-----------------------+-----+------+-----+----------+-----------+--------+
| subject               | set | revs | its | mem_peak | mode      | rstdev |
+-----------------------+-----+------+-----+----------+-----------+--------+
| benchWith5Middleware  | 0   | 1000 | 10  | 1.097mb  | 64.452μs  | ±4.70% |
| benchWith25Middleware | 0   | 1000 | 10  | 1.125mb  | 270.484μs | ±5.25% |
| benchWith50Middleware | 0   | 1000 | 10  | 1.161mb  | 524.930μs | ±1.93% |
| benchWith75Middleware | 0   | 1000 | 10  | 1.196mb  | 783.698μs | ±2.34% |
+-----------------------+-----+------+-----+----------+-----------+--------+

DispatcherBench
+-----------------------+-----+------+-----+----------+-----------+--------+
| subject               | set | revs | its | mem_peak | mode      | rstdev |
+-----------------------+-----+------+-----+----------+-----------+--------+
| benchWith5Middleware  | 0   | 1000 | 10  | 1.107mb  | 65.922μs  | ±5.00% |
| benchWith25Middleware | 0   | 1000 | 10  | 1.151mb  | 277.338μs | ±2.22% |
| benchWith50Middleware | 0   | 1000 | 10  | 1.206mb  | 529.684μs | ±2.18% |
| benchWith75Middleware | 0   | 1000 | 10  | 1.271mb  | 780.429μs | ±2.18% |
+-----------------------+-----+------+-----+----------+-----------+--------+

devanych and others added 2 commits July 15, 2021 10:16

Fix stack cleanup and performance in MiddlewareDispatcher

194420a

Apply fixes from StyleCI

b713589

devanych added the status:code review The pull request needs review. label Jul 15, 2021

devanych requested a review from a team July 15, 2021 07:19

roxblnfk approved these changes Jul 15, 2021

View reviewed changes

Add comment about fixing a memory leak

c705215

devanych merged commit 8b5b8e2 into master Jul 15, 2021

devanych deleted the fix-performance branch July 15, 2021 07:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix stack cleanup and performance in MiddlewareDispatcher #37

Fix stack cleanup and performance in MiddlewareDispatcher #37

devanych commented Jul 15, 2021

roxblnfk left a comment •

edited

Loading

roxblnfk commented Jul 15, 2021 •

edited

Loading

Fix stack cleanup and performance in MiddlewareDispatcher #37

Fix stack cleanup and performance in MiddlewareDispatcher #37

Conversation

devanych commented Jul 15, 2021

roxblnfk left a comment • edited Loading

Choose a reason for hiding this comment

roxblnfk commented Jul 15, 2021 • edited Loading

Benches (php 8.0.7)

Before fix:

After fix:

roxblnfk left a comment •

edited

Loading

roxblnfk commented Jul 15, 2021 •

edited

Loading