Optimize MiddlewareFactory performance (#75)

random-rage · vjik · web-flow · commit 1fe9b495c3a8 · 2023-03-31T14:05:39.000+03:00
* Optimize MiddlewareFactory performance * Add line to changelog (#74) * Update CHANGELOG.md --------- Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 5.0.1 under development
 
-- no changes in this release.
+- Enh #75: Optimize `MiddlewareFactory` performance (@random-rage)
 
 ## 5.0.0 January 09, 2023
 
diff --git a/src/MiddlewareFactory.php b/src/MiddlewareFactory.php
@@ -12,6 +12,7 @@
 use Psr\Http\Server\RequestHandlerInterface;
 use ReflectionClass;
 use ReflectionFunction;
+use ReflectionParameter;
 use Yiisoft\Definitions\ArrayDefinition;
 use Yiisoft\Definitions\Exception\InvalidConfigException;
 use Yiisoft\Definitions\Helpers\DefinitionValidator;
@@ -141,13 +142,17 @@ private function createCallableWrapper(callable $callback): MiddlewareInterface
     {
         return new class ($callback, $this->container, $this->parametersResolver) implements MiddlewareInterface {
             private $callback;
+            /** @var ReflectionParameter[] */
+            private array $callableParameters;
 
             public function __construct(
                 callable $callback,
                 private ContainerInterface $container,
                 private ?ParametersResolverInterface $parametersResolver
             ) {
                 $this->callback = $callback;
+                $callback = Closure::fromCallable($callback);
+                $this->callableParameters = (new ReflectionFunction($callback))->getParameters();
             }
 
             public function process(
@@ -158,7 +163,7 @@ public function process(
                 if ($this->parametersResolver !== null) {
                     $parameters = array_merge(
                         $parameters,
-                        $this->parametersResolver->resolve($this->getCallableParameters(), $request)
+                        $this->parametersResolver->resolve($this->callableParameters, $request)
                     );
                 }
                 /** @var MiddlewareInterface|mixed|ResponseInterface $response */
@@ -176,16 +181,6 @@ public function __debugInfo(): array
             {
                 return ['callback' => $this->callback];
             }
-
-            /**
-             * @return \ReflectionParameter[]
-             */
-            private function getCallableParameters(): array
-            {
-                $callback = Closure::fromCallable($this->callback);
-
-                return (new ReflectionFunction($callback))->getParameters();
-            }
         };
     }
 
@@ -196,6 +191,9 @@ private function getCallableParameters(): array
     private function createActionWrapper(string $class, string $method): MiddlewareInterface
     {
         return new class ($this->container, $this->parametersResolver, $class, $method) implements MiddlewareInterface {
+            /** @var ReflectionParameter[] */
+            private array $actionParameters;
+
             public function __construct(
                 private ContainerInterface $container,
                 private ?ParametersResolverInterface $parametersResolver,
@@ -204,6 +202,9 @@ public function __construct(
                 /** @var non-empty-string */
                 private string $method
             ) {
+                $this->actionParameters = (new ReflectionClass($this->class))
+                    ->getMethod($this->method)
+                    ->getParameters();
             }
 
             public function process(
@@ -216,7 +217,7 @@ public function process(
                 if ($this->parametersResolver !== null) {
                     $parameters = array_merge(
                         $parameters,
-                        $this->parametersResolver->resolve($this->getActionParameters(), $request)
+                        $this->parametersResolver->resolve($this->actionParameters, $request)
                     );
                 }
 
@@ -229,16 +230,6 @@ public function process(
                 throw new InvalidMiddlewareDefinitionException([$this->class, $this->method]);
             }
 
-            /**
-             * @throws \ReflectionException
-             *
-             * @return \ReflectionParameter[]
-             */
-            private function getActionParameters(): array
-            {
-                return (new ReflectionClass($this->class))->getMethod($this->method)->getParameters();
-            }
-
             public function __debugInfo()
             {
                 return [
