Skip to content

✨ Pydantic v2 migration#470

Closed
yezz123 wants to merge 7 commits intomainfrom
pydantic2
Closed

✨ Pydantic v2 migration#470
yezz123 wants to merge 7 commits intomainfrom
pydantic2

Conversation

@yezz123
Copy link
Copy Markdown
Owner

@yezz123 yezz123 commented Jun 24, 2023

No description provided.

@yezz123 yezz123 added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 24, 2023
@yezz123 yezz123 self-assigned this Jun 24, 2023
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
authx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:54pm
authx-old ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:54pm

@vercel vercel Bot temporarily deployed to Preview – authx-old June 24, 2023 20:22 Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (90dd778) 90.24% compared to head (1c8a1e4) 90.30%.
Report is 2 commits behind head on main.

❗ Current head 1c8a1e4 differs from pull request most recent head fe8d036. Consider uploading reports for the commit fe8d036 to get more accurate results

Files Patch % Lines
authx/schema.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   90.24%   90.30%   +0.05%     
==========================================
  Files          26       25       -1     
  Lines        1282     1165     -117     
  Branches      205      183      -22     
==========================================
- Hits         1157     1052     -105     
+ Misses         83       81       -2     
+ Partials       42       32      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vercel vercel Bot temporarily deployed to Preview – authx-old June 24, 2023 20:29 Inactive
@vercel vercel Bot temporarily deployed to Preview – authx-old June 24, 2023 21:20 Inactive
@vercel vercel Bot temporarily deployed to Preview – authx-old June 24, 2023 21:26 Inactive
@yezz123 yezz123 linked an issue Jul 2, 2023 that may be closed by this pull request
✨ Start Integrating Pydantic V2 #461
Closed
@vercel vercel Bot temporarily deployed to Preview – authx-old July 23, 2023 18:58 Inactive
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patrick91
Copy link
Copy Markdown

patrick91 commented Sep 30, 2023

@yezz123 is there anything I can do to help you land this PR?

@yezz123
Copy link
Copy Markdown
Owner Author

yezz123 commented Oct 1, 2023

Hey, @patrick91, thanks for reaching out and your willingness to help 🙏🏻

I really appreciate it. I've been taking some time off recently, but I'm now back and ready to start reviewing the changes in this PR and push some updates.

My main idea of supporting both versions of Pydantic sounds excellent and will definitely help maintain broader compatibility.

Please let me know if you have any specific suggestions or areas you'd like to contribute to.

Thanks again for your support 🙌🏻

@vercel vercel Bot temporarily deployed to Preview – authx-old October 1, 2023 03:52 Inactive
@vercel vercel Bot temporarily deployed to Preview – authx-old October 2, 2023 02:22 Inactive
@vercel vercel Bot temporarily deployed to Preview – authx-old October 14, 2023 20:30 Inactive
@vercel vercel Bot temporarily deployed to Preview – authx-old October 15, 2023 03:02 Inactive
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vercel vercel Bot temporarily deployed to Preview – authx-old October 15, 2023 03:05 Inactive
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vercel vercel Bot temporarily deployed to Preview – authx-old November 28, 2023 22:54 Inactive
@artemonsh
Copy link
Copy Markdown

artemonsh commented Jan 16, 2024

any updates?

@yezz123
Copy link
Copy Markdown
Owner Author

yezz123 commented Jan 16, 2024

Any updates?

I'm thinking of keeping this one until I finish the documentation and then I will get back to it, it's on my milestone 🙏🏻

@yezz123 yezz123 removed a link to an issue Feb 8, 2024
✨ Start Integrating Pydantic V2 #461
Closed
@yezz123 yezz123 closed this Feb 8, 2024
@yezz123 yezz123 deleted the pydantic2 branch February 8, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yezz123 yezz123

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request

Projects

@yezz123's Planning
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yezz123 @patrick91 @artemonsh @barraponto