edit: escape backslashes when quoting dotenv values on write - #450

Thanks! The round trip through magpie's own reader is right, but the file's real reader is Gemini CLI, and its dotenv (npm dotenv, checked against the 0.62 bundle) only expands \n/\r inside double quotes — \\ and \" stay literal. So with this change C:\Program Files\key x is written as "C:\\Program Files\\key x" and Gemini reads C:\\Program Files\\key x (it read it correctly before). Could you write the value single-quoted when it contains no ' or newline (K='C:\new folder\tmp')? Both npm dotenv and GetEnvFile take single-quoted text literally, so it round-trips exactly for both; keep the double-quoted form only as the fallback for values containing '. A test that also checks the written line (K='…') would pin it. (#439 has just been merged, so please rebase on main.)

Thanks, that makes sense. Merged current main (clean, #439's parser is preserved) and pushed 0571cc0.

Values that need quoting are now written single-quoted when they contain no ', CR or LF, so K='C:\new folder\tmp' is read literally by both GetEnvFile and a dotenv that only expands escapes in double quotes. The double-quoted escaped form stays as the fallback for values with ' or newlines. The round-trip test now also asserts the exact written line.

I checked the single-quoted path against the current npm dotenv (18.0.5): it parses back exactly. I did not test against Gemini CLI's pinned 0.62 bundle, so that part rests on your check. internal/edit and the Gemini/Kimi agent tests pass; I did not run the full agent suite.

Thanks — re-reviewed at 0571cc0, merged onto current main: looks good to merge.

I checked the written file against the dotenv parser bundled in Gemini CLI 0.62.0 (copied verbatim from the bundle), npm dotenv 17.4.2, python-dotenv 1.2.4, godotenv 1.5.1 and magpie's GetEnvFile: Windows paths like C:\new folder\tmp, say "hi", $HOME/x y and literal backslash sequences now come back exactly from all five (on main, Gemini read the Windows path with a doubled backslash). In a sandbox HOME, magpie gemini auth api-key with a key containing C:\new\tmp writes it single-quoted, keeps the user's other lines, and Gemini's parser reads it back unchanged.

TestEnvBackslashRoundtrip fails without the env.go change; vet, the darwin/linux/windows builds and go test -tags nogui ./... pass.

(Only remaining corner, not blocking: a value with both ' and \ still can't round-trip through Gemini's dotenv, which can't express it in double quotes. Magpie never writes such values here.)