Skip to content

feat: add support of light theme#195

Merged
yetone merged 1 commit intoyetone:mainfrom
tang-hi:add-light-theme
Aug 24, 2024
Merged

feat: add support of light theme#195
yetone merged 1 commit intoyetone:mainfrom
tang-hi:add-light-theme

Conversation

@tang-hi
Copy link
Copy Markdown
Contributor

@tang-hi tang-hi commented Aug 24, 2024

Users can set a light theme by adjusting the config. This allows Avante to better match their setup if they're using a light theme, like I do. :)
Below is a preview from my own nvim
20240825_00h28m16s_grim

@yetone yetone merged commit 8b55833 into yetone:main Aug 24, 2024
Comment thread lua/avante/config.lua
hints = {
enabled = true,
},
--- @class AvanteThemeConfig
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this. Users should change the target color highlight group if they are using a light theme.

I'm fine with updates on the documentation of the highlight group for people to use. Other than that, this would not be maintainable.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‌‌‌‌Makes sense, I'll revert it first. cc @tang-hi

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#201 looks better. I'm glad to see such a quick response! thanks

yetone added a commit that referenced this pull request Aug 24, 2024
gub-7 pushed a commit to gub-7/avante.nvim that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants