Skip to content

feat(batcher): poll for unlock events and remove users with unlocked funds #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 20 commits into from
Sep 19, 2025
Merged

feat(batcher): poll for unlock events and remove users with unlocked funds #2123

MauroToscano merged 20 commits into from
Sep 19, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented Sep 16, 2025 •
edited
Loading

Feat(batcher): Poll for unlock events and remove users with unlocked funds

Description

This PR fetches BalanceUnlocked events from BatcherPaymentService to check if an user has proofs in the queue and has unlocked their funds.
In that case, the batcher will remove their proofs until the user locks funds again to avoid a withdrawal and trying to discount balace from a user without funds deposited.

Closes #2122

How to Test

  1. Start anvil

  2. Set balance_unlock_polling_interval_seconds to 60 in config-files/config-batcher.yaml. So the polling is executed every 1 minute

  3. Start batcher

  4. Deposit funds

aligned deposit-to-batcher \
    --amount 1ether \
    --private_key 0xdbda1821b80551c9d65939329250298aa3472ba22feea921c0cf5d620ea67b97 \
    --network devnet \
    --rpc_url http://localhost:8545
  1. Send a proof with low fee
aligned submit \
    --proving_system Risc0 \
    --proof ./scripts/test_files/risc_zero/no_public_inputs/risc_zero_no_pub_input_3_0_3.proof \
    --vm_program ./scripts/test_files/risc_zero/no_public_inputs/risc_zero_no_pub_input_id_3_0_3.bin \
    --rpc_url http://localhost:8545 \
    --network devnet \
    --custom_fee_estimate 16 \
    --private_key 0xdbda1821b80551c9d65939329250298aa3472ba22feea921c0cf5d620ea67b97 \
    --random_address

You can send multiple proofs (less than 16 :p)

  1. Unlock your funds
cast send 0x7bc06c482DEAd17c0e297aFbC32f6e63d3846650  "unlock()" \
    --rpc-url http://localhost:8545 \
    --private-key 0xdbda1821b80551c9d65939329250298aa3472ba22feea921c0cf5d620ea67b97
  1. You should see logs like:
[2025-09-16T21:27:14Z INFO  aligned_batcher] Found 1 BalanceUnlocked events in blocks 770 to 870
[2025-09-16T21:27:14Z INFO  aligned_batcher] Processing BalanceUnlocked event for user: 0x23618e81e3f5cdf7f54c3d65f7fbc0abf5b21e8f

And the user should receive the error User funds have been unlocked and proofs removed from queue.

Other tests cases:

Unlock and lock funds. The batcher should not eject the user proofs

To lock funds again, use

cast send 0x7bc06c482DEAd17c0e297aFbC32f6e63d3846650  "lock()" \
    --rpc-url http://localhost:8545 \
    --private-key 0xdbda1821b80551c9d65939329250298aa3472ba22feea921c0cf5d620ea67b97

Type of change

  • New feature
  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change crates/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this Sep 16, 2025
@JuArce JuArce marked this pull request as ready for review September 16, 2025 21:45
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 17, 2025
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General flow worked alright for me

MauroToscano
MauroToscano reviewed Sep 17, 2025
View reviewed changes
MauroToscano
MauroToscano reviewed Sep 17, 2025
View reviewed changes
MarcosNicolau
MarcosNicolau reviewed Sep 18, 2025
View reviewed changes
@MarcosNicolau
Copy link
Member

MarcosNicolau commented Sep 18, 2025

Worked correctly for me following #2119 instructions, but the CI is failing for some reason

@JuArce
Copy link
Collaborator Author

JuArce commented Sep 18, 2025

Ci is working now

MauroToscano
MauroToscano reviewed Sep 19, 2025
View reviewed changes
MauroToscano
MauroToscano reviewed Sep 19, 2025
View reviewed changes
@MauroToscano MauroToscano added this pull request to the merge queue Sep 19, 2025
Merged via the queue into staging with commit 8924dbe Sep 19, 2025
3 checks passed
@MauroToscano MauroToscano deleted the 2122-featbatcher-poll-for-unlock-events-and-remove-users-with-unlocked-funds branch September 19, 2025 18:46
@JuArce JuArce linked an issue Sep 22, 2025 that may be closed by this pull request
feat(batcher): poll for unlock events and remove users with unlocked funds #2122
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(batcher): poll for unlock events and remove users with unlocked funds

4 participants

@JuArce @MarcosNicolau @MauroToscano