hotfix(operator): retry logic for batches download #2030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauroToscano
approved these changes
Jul 29, 2025
MauroToscano
requested changes
Jul 29, 2025
Contributor
MauroToscano
left a comment
MauroToscano
left a comment
There was a problem hiding this comment.
This doesn't seem to fix the issue
MauroToscano
approved these changes
Jul 29, 2025
MarcosNicolau
approved these changes
Jul 29, 2025
MauroToscano
deleted the
2029-hotifxoperator-retry-logic-for-batches-download
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry logic for batches download
Retry is not working when the server accepts the TCP connection but headers are not sent. To test you can change the S3 bucket address in the code to a localhost one, and run this:
# Accept connections but never send response ncat -l -p 8080 -kor
ncat -l -p 8080 -k --sh-exec 'sleep 3600'On staging branch you will see no retries, on this one, the retries will be done properly.
We also changed the timeout for the s3 fetching task to 3 min, since with the retry logic it could last more than 1 min
Description
closes #2029
Type of change
Checklist
testnet, everything else tostaging