fix: rename groth16/plonk to gnark_groth16 and gnark_plonk to avoid ambiguity with circom #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-gnark_groth16-and-gnark_plonk-to-avoid-ambiguity-with-circom # Conflicts: # Makefile # crates/batcher/src/zk_utils/mod.rs # crates/cli/send_proof_with_random_address.sh
maximopalopoli
approved these changes
Jun 25, 2025
MarcosNicolau
approved these changes
Jun 26, 2025
MauroToscano
approved these changes
Jun 26, 2025
MauroToscano
deleted the
1998-fix-rename-groth16plonk-to-gnark_groth16-and-gnark_plonk-to-avoid-ambiguity-with-circom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename groth16/plonk to gnark_groth16 and gnark_plonk to avoid ambiguity with circom
Description
This PR changes gnark names to avoid ambiguity with circom
Closes #1998
Type of change
Checklist
testnet, everything else tostaging