Skip to content

Conversation

@maximopalopoli
Copy link
Collaborator

@maximopalopoli maximopalopoli commented Jun 24, 2025

Description

This PR removes some unnecessary clones for certain variables in the CLI crate and also retrieves the used network only once to avoid converting the network argument on every use of the network type.

Note: This PR should not be merged before #1989, since it is based on it

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@maximopalopoli maximopalopoli self-assigned this Jun 24, 2025
@maximopalopoli maximopalopoli marked this pull request as ready for review June 24, 2025 17:22
@JuArce JuArce added this pull request to the merge queue Jul 15, 2025
Merged via the queue into staging with commit f8a5cef Jul 15, 2025
3 checks passed
@JuArce JuArce deleted the refactor/avoid-cloning-immutable-values branch July 15, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants