fix: update explorer URL printed after proof submission #1989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauroToscano
approved these changes
Jun 19, 2025
MauroToscano
approved these changes
Jun 19, 2025
Contributor
MauroToscano
left a comment
MauroToscano
left a comment
There was a problem hiding this comment.
A follow up making the Network a reference would be nice, to avoid all this cloning. Maybe wallet can be a reference too
JuArce
requested changes
Jun 23, 2025
| let base_url = match submit_args.network.clone().into() { | ||
| // Note: in case the explorer address changes for other networks, we should add an arm to this | ||
| // match with that network since the default URL used here is the mainnet one | ||
| Network::Holesky => "https://holesky.explorer.alignedlayer.com/batches/0x", |
Collaborator
There was a problem hiding this comment.
There is missing to add the other networks
- Stage
- Mainnet
- MainnetStage
- Devnet
Generally we use devnet as default
JuArce
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the explorer URL printed after a proof submission. Also left a comment explaining that the default URL used is the one for mainnet, and in case the explorer's URL changes for another network, it should change here too.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging