Skip to content

chore(makefile): unify naming conventions in targets #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 5 commits into from
Jun 11, 2025
Merged

chore(makefile): unify naming conventions in targets #1979

MauroToscano merged 5 commits into from
Jun 11, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented Jun 5, 2025 •
edited
Loading

Unify naming conventions in targets

Description

This PR renames the makefile targets to use the same naming convention.

You can check all targets with make help

Closes #1978

Type of change

  • Makefile
  • Docs

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this Jun 5, 2025
@JuArce
chore: improve makefile targets
029dea2 
docs: update to new targets
@JuArce JuArce linked an issue Jun 6, 2025 that may be closed by this pull request
chore(makefile): unify naming conventions in targets #1978
Closed
@JuArce JuArce marked this pull request as ready for review June 6, 2025 18:13
MarcosNicolau
MarcosNicolau approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor is like that moment in a rom-com when everything just clicks. I didn’t know how much I needed you until you showed up and made everything better!

JuArce added 2 commits June 6, 2025 19:05
@JuArce
Merge branch 'refs/heads/staging' into 1978-choremakefile-unify-namin…
b300b54 
…g-conventions-in-targets

# Conflicts:
#	Makefile
@JuArce
Merge branch 'refs/heads/staging' into 1978-choremakefile-unify-namin…
5d651af 
…g-conventions-in-targets

# Conflicts:
#	Makefile
@MauroToscano MauroToscano added this pull request to the merge queue Jun 11, 2025
Merged via the queue into staging with commit 17ea3a9 Jun 11, 2025
3 checks passed
@MauroToscano MauroToscano deleted the 1978-choremakefile-unify-naming-conventions-in-targets branch June 11, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore(makefile): unify naming conventions in targets

4 participants

@JuArce @MauroToscano @MarcosNicolau